From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com, Stefan Hrdlicka <s.hrdlicka@proxmox.com>
Subject: Re: [pve-devel] [PATCH docs 2/2] cifs: add options parameter (fix #2920)
Date: Thu, 28 Jul 2022 12:26:50 +0200 [thread overview]
Message-ID: <c70feba9-29aa-d57f-67ce-b9ca31efd2ca@proxmox.com> (raw)
In-Reply-To: <20220513135550.1856651-3-s.hrdlicka@proxmox.com>
Am 13.05.22 um 15:55 schrieb Stefan Hrdlicka:
> Signed-off-by: Stefan Hrdlicka <s.hrdlicka@proxmox.com>
> ---
> this depends on 1/2 since this changes the documentation :)
>
> pve-storage-cifs.adoc | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/pve-storage-cifs.adoc b/pve-storage-cifs.adoc
> index bb4b902..60775a4 100644
> --- a/pve-storage-cifs.adoc
> +++ b/pve-storage-cifs.adoc
> @@ -57,6 +57,10 @@ path::
>
> The local mount point. Optional, defaults to `/mnt/pve/<STORAGE_ID>/`.
>
> +options::
> +
> +CIFS mount options (see `man mount.cifs`).
Maybe add "Additional" and briefly mention that we set some options like
username, vers, etc. based on the other settings?
> +
> .Configuration Example (`/etc/pve/storage.cfg`)
> ----
> cifs: backup
> @@ -64,6 +68,7 @@ cifs: backup
> server 10.0.0.11
> share VMData
> content backup
> + options noserverino,cache=loose
Reading the man page, cache=loose sounds rather dangerous! I'd rather
have the example use something that can't lead to data corruption in
some scenarios :S
> username anna
> smbversion 3
>
prev parent reply other threads:[~2022-07-28 10:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-13 13:55 [pve-devel] [PATCH storage 0/2] cifs plugin - add options parameter Stefan Hrdlicka
2022-05-13 13:55 ` [pve-devel] [PATCH storage 1/2] add options parameter to cifs plugin (fixes #2920) Stefan Hrdlicka
2022-07-28 10:26 ` Fiona Ebner
2022-05-13 13:55 ` [pve-devel] [PATCH docs 2/2] cifs: add options parameter (fix #2920) Stefan Hrdlicka
2022-07-28 10:26 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c70feba9-29aa-d57f-67ce-b9ca31efd2ca@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hrdlicka@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox