Re: [pve-devel] [PATCH-SERIES v8 pve-storage/qemu-server] add external qcow2 snapshot support

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 14.07.25 um 13:15 schrieb Fabian Grünbichler:
>> Thomas Lamprecht <t.lamprecht@proxmox.com> hat am 14.07.2025 13:11 CEST geschrieben:
>> Albeit, taking a step back, I'm not so sure if that really helps the user?
>> I.e., what's something actionable they can do when seeing such a warning?
>> Is it just to signal "this is a tech preview, be wary"? If, then I'd rather
>> just signal that in the storage edit/add window.
> 
> for LVM, there is no new plugin or storage option, the plugin just gains
> a new supported format and that has the experimental status. we could
> guard that (like in the DirPlugin) with the external-snapshots flag, and
> only allow qcow2 formatted volumes if that is set - that way, users would
> need to "opt-in" to the experimental behaviour by creating a new storage
> with that flag set. if we don't do that, then the only thing that we can
> warn about is qcow2 *being used*, and there is no central place for that
> as all existing LVM storages would get that support "over night" (once
> they upgrade).

Ah okay, I actually thought it already worked that way when I saw the
new flag getting added.

Might be indeed safer and more telling if we couple allowing it with that
flag being set. We could then change the default of that flag for a future
release, once we got more exposure and maybe improved UX polishing a bit
and if we think it helps users. But it might not be bad to require an
explicit decision for this.

If we really just enforce that check on volume creation, we could even
allow changing the flag for an existing storage, as that would be a bit
more convenient, and, more importantly, better than nudge the admin towards
adding the same storage twice, which we do not support.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel