From: Fiona Ebner <f.ebner@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH qemu-server] qmp helpers: device add: use HMP interface
Date: Tue, 4 Feb 2025 16:34:34 +0100 [thread overview]
Message-ID: <c66b4469-a47c-45c2-b9ed-9d540fcd5aa8@proxmox.com> (raw)
In-Reply-To: <20250204152428.146743-1-f.ebner@proxmox.com>
Am 04.02.25 um 16:24 schrieb Fiona Ebner:
> The timeout of 60 seconds is used, because that is the same that's
> currently used by the 'drive_add' HMP commands and a too low timeout
> is known to cause issues [0]. While 'drive_del' uses 10 minutes, there
> were no issues reported with the 'device_del' operations using the
> default timeout until now, but it still makes sense to increase,
> because for some devices IO might need to happen during detach, so use
> 60 seconds for now too.
Actually, I'm a bit torn with the 60 seconds. We really didn't have many
reports of issues here and this might feel like too long from a user
perspective. Increasing in specific cases can always still be done, but
device-plug is often done interactively, so might be bad UX to have too
much. The bug report [0] mentions that 7 seconds is enough for the
operation, so maybe using 30 seconds as the timeout is better?
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-02-04 15:34 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-04 15:24 Fiona Ebner
2025-02-04 15:34 ` Fiona Ebner [this message]
2025-02-04 15:51 ` Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c66b4469-a47c-45c2-b9ed-9d540fcd5aa8@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal