[pve-devel] [PATCH manager] ui: tag: only set lowercased tags

[pve-devel] [PATCH manager] ui: tag: only set lowercased tags

[Maximiliano Sandoval]

At the moment, the color of the preview tag won't match the final tag
once it is added if the tag contained uppercase letters. With this patch
the color in the tag being created will match the color of the final tag
added to a guest.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 www/manager6/form/Tag.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/manager6/form/Tag.js b/www/manager6/form/Tag.js
index 6b1d6aa55..399644899 100644
--- a/www/manager6/form/Tag.js
+++ b/www/manager6/form/Tag.js
@@ -181,6 +181,7 @@ Ext.define('Proxmox.form.Tag', {
     setTag: function(tag) {
 	let me = this;
 	let oldtag = me.tag;
+	tag = tag.toLowerCase();
 	me.tag = tag;
 
 	clearTimeout(me.colorTimeout);
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager] ui: tag: only set lowercased tags

[Dominik Csapak]

On 3/19/25 09:58, Maximiliano Sandoval wrote:
> At the moment, the color of the preview tag won't match the final tag
> once it is added if the tag contained uppercase letters. With this patch
> the color in the tag being created will match the color of the final tag
> added to a guest.
> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>   www/manager6/form/Tag.js | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/www/manager6/form/Tag.js b/www/manager6/form/Tag.js
> index 6b1d6aa55..399644899 100644
> --- a/www/manager6/form/Tag.js
> +++ b/www/manager6/form/Tag.js
> @@ -181,6 +181,7 @@ Ext.define('Proxmox.form.Tag', {
>       setTag: function(tag) {
>   	let me = this;
>   	let oldtag = me.tag;
> +	tag = tag.toLowerCase();
>   	me.tag = tag;
>   
>   	clearTimeout(me.colorTimeout);


this would only be valid if we could not have case sensitive tags,
but this is configurable in the datacenter options. So what we want here
is to make behavior dependent on the case-sensitivity setting.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel