From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH manager] ui: tag: only set lowercased tags
Date: Wed, 19 Mar 2025 10:05:46 +0100 [thread overview]
Message-ID: <c66737a8-3914-49cd-8773-4c3ffcb5e796@proxmox.com> (raw)
In-Reply-To: <20250319085809.84343-1-m.sandoval@proxmox.com>
On 3/19/25 09:58, Maximiliano Sandoval wrote:
> At the moment, the color of the preview tag won't match the final tag
> once it is added if the tag contained uppercase letters. With this patch
> the color in the tag being created will match the color of the final tag
> added to a guest.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> www/manager6/form/Tag.js | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/www/manager6/form/Tag.js b/www/manager6/form/Tag.js
> index 6b1d6aa55..399644899 100644
> --- a/www/manager6/form/Tag.js
> +++ b/www/manager6/form/Tag.js
> @@ -181,6 +181,7 @@ Ext.define('Proxmox.form.Tag', {
> setTag: function(tag) {
> let me = this;
> let oldtag = me.tag;
> + tag = tag.toLowerCase();
> me.tag = tag;
>
> clearTimeout(me.colorTimeout);
this would only be valid if we could not have case sensitive tags,
but this is configurable in the datacenter options. So what we want here
is to make behavior dependent on the case-sensitivity setting.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-03-19 9:06 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-03-19 8:58 Maximiliano Sandoval
2025-03-19 9:05 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c66737a8-3914-49cd-8773-4c3ffcb5e796@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal