From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fabian Ebner <f.ebner@proxmox.com>,
Oguz Bektas <o.bektas@proxmox.com>
Subject: Re: [pve-devel] [PATCH common] fix #3747: download_file_from_url: trim whitespace before comparing checksum
Date: Fri, 3 Dec 2021 11:11:20 +0100 [thread overview]
Message-ID: <c5ed480b-3810-9926-aae6-4597bba32600@proxmox.com> (raw)
In-Reply-To: <6670482a-986b-d81d-bde1-96d0c8de48ee@proxmox.com>
On 03.12.21 09:03, Fabian Ebner wrote:
> Am 02.12.21 um 14:38 schrieb Oguz Bektas:
>> so that we don't get checksum mismatch in case the user accidentally
>> copies whitespace in the checksum field.
>>
>
> Isn't this better done in the UI? Or at least upon parameter validation (but we don't do this for any other parameter, or)?.
>
Yeah, I do not like messing with the checksum in the backend to much,
maybe we can enforce the format such that it doesn't allow any whitespace
and explicitly errors out for api users that send some.
I trimmed for now in the frontend:
https://git.proxmox.com/?p=pve-manager.git;a=commitdiff;h=9e9a3abd0a5eedc76a41f6ebcd719dca72d536b8
prev parent reply other threads:[~2021-12-03 10:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-02 13:38 Oguz Bektas
2021-12-03 8:03 ` Fabian Ebner
2021-12-03 9:20 ` Fabian Grünbichler
2021-12-03 10:11 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5ed480b-3810-9926-aae6-4597bba32600@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=o.bektas@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox