From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pve-devel] [PATCH storage] BTRFSPlugin: reuse DirPlugin update/get_volume_attribute
Date: Mon, 2 May 2022 08:36:26 +0200 [thread overview]
Message-ID: <c5e664da-59a2-eeec-8547-4c78aaa90d7e@proxmox.com> (raw)
In-Reply-To: <20220429100030.809902-1-d.csapak@proxmox.com>
Am 4/29/22 um 12:00 schrieb Dominik Csapak:
> this allows setting notes+protected for backups on btrfs
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> PVE/Storage/BTRFSPlugin.pm | 20 ++++++++++++++++++--
> 1 file changed, 18 insertions(+), 2 deletions(-)
>
> diff --git a/PVE/Storage/BTRFSPlugin.pm b/PVE/Storage/BTRFSPlugin.pm
> index be613f4..dd5f139 100644
> --- a/PVE/Storage/BTRFSPlugin.pm
> +++ b/PVE/Storage/BTRFSPlugin.pm
> @@ -138,9 +138,25 @@ sub status {
> return PVE::Storage::DirPlugin::status($class, $storeid, $scfg, $cache);
> }
>
> -# TODO: sub get_volume_attribute {}
> +# FIXME remove on the next APIAGE reset.
> +# Deprecated, use get_volume_attribute instead.
> +sub get_volume_notes {
> + return PVE::Storage::DirPlugin::get_volume_notes(@_);
> +}
> +
> +# FIXME remove on the next APIAGE reset.
> +# Deprecated, use update_volume_attribute instead.
> +sub update_volume_notes {
> + return PVE::Storage::DirPlugin::update_volume_notes( @_);
> +}
makes no sense to add these? they are deprecated and unused anyway
>
> -# TODO: sub update_volume_attribute {}
> +sub get_volume_attribute {
> + return PVE::Storage::DirPlugin::get_volume_attribute(@_);
> +}
> +
> +sub update_volume_attribute {
> + return PVE::Storage::DirPlugin::update_volume_attribute(@_);
> +}
This is so trivial that I'm wondering if Wolfgang had a reason to not do it for the
original get_volume_notes that was there long before the BTRFS plugin got added..
>
> # croak would not include the caller from within this module
> sub __error {
next prev parent reply other threads:[~2022-05-02 6:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-29 10:00 Dominik Csapak
2022-05-02 6:36 ` Thomas Lamprecht [this message]
2022-05-02 6:48 ` Dominik Csapak
2022-05-02 6:51 ` Dominik Csapak
2022-05-02 7:04 ` Thomas Lamprecht
2022-05-02 7:20 ` Dominik Csapak
2022-05-25 10:48 Wolfgang Bumiller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5e664da-59a2-eeec-8547-4c78aaa90d7e@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox