From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Fiona Ebner <f.ebner@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [PATCH qemu 1/2] update submodule and patches to QEMU 10.2.1
Date: Wed, 18 Mar 2026 10:57:24 +0100 [thread overview]
Message-ID: <c5594ad8-2eb9-44b5-b0f8-c2a55160aea9@proxmox.com> (raw)
In-Reply-To: <9f4cf875-5b5c-4343-851f-8a65fc5879da@proxmox.com>
Am 18.03.26 um 10:46 schrieb Fiona Ebner:
> Am 17.03.26 um 5:58 PM schrieb Thomas Lamprecht:
>> Am 12.03.26 um 13:13 schrieb Fiona Ebner:
>>> @@ -715,7 +715,12 @@ index 0000000000..56e0fa6c69
>>> +
>>> + migration_incoming_state_destroy();
>>> + if (ret < 0) {
>>> -+ error_setg_errno(errp, -ret, "Error while loading VM state");
>>> ++ if (local_err) {
>>> ++ error_setg_errno(errp, -ret, "Error while loading VM state - %s",
>>> ++ error_get_pretty(local_err));
>>
>> Would we need to free the local_err here? But in any case a tiny nit
>> and not really relevant in terms of leaking memory due to being in
>> a rather unlikely error branch.
>
> Yes, you are right. If error_propagate() is not used, a local error must
> be freed. There are quite a few more instances where errors are not
> freed in the surrounding code. There is an error_propagate_prepend()
> helper that could be used.
I mean, if QEMU exits due to the error anyway it won't really matter.
> Should I send a v2 or a follow-up?
Can be addressed in a follow-up.
next prev parent reply other threads:[~2026-03-18 9:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-12 11:44 [PATCH-SERIES qemu 0/2] " Fiona Ebner
2026-03-12 11:44 ` [PATCH qemu 1/2] update submodule and patches to " Fiona Ebner
2026-03-17 16:58 ` Thomas Lamprecht
2026-03-18 9:47 ` Fiona Ebner
2026-03-18 9:57 ` Thomas Lamprecht [this message]
2026-03-12 11:44 ` [PATCH qemu 2/2] stable fixes for " Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c5594ad8-2eb9-44b5-b0f8-c2a55160aea9@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox