public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Stoiko Ivanov <s.ivanov@proxmox.com>
Subject: Re: [pve-devel] [PATCH lxc 0/2] fix apparmor rules and improve cgroupv2 experience
Date: Wed, 9 Sep 2020 21:06:46 +0200	[thread overview]
Message-ID: <c556ac5b-e501-7918-441c-5d4c735f6814@proxmox.com> (raw)
In-Reply-To: <20200722110505.8210-1-s.ivanov@proxmox.com>

On 22.07.20 13:05, Stoiko Ivanov wrote:
> This patchset addresses 2 minor inconveniences I ran into, while running my
> host with 'systemd.unified_cgroup_hierarchy=1':
> 
> * apparmor mount denies for '/proc/sys/kernel/random/boot_id' (this happens
>   irrespective of the cgroup-layout
> * having to add
>   `lxc.init.cmd: /lib/systemd/systemd systemd.unified_cgroup_hierarchy=1`
>   to all my container configs (for debian and arch containers at least
>   alpine runs without issues) - see [0] for a discussion of the topic
> 
> While investigating this I noticed that the fixes for both issues were already
> on upstream/master (with one small other fix in between) - so instead of
> cherry-picking both patches I fast-forwarded to the last needed commit.
> Glad to resend with the patches cherry-picked and added to our patchqueue.
> 
> I would probably submit the apparmor fix upstream (after a quick check by
> another set of eyes :)
> 
> [0] https://github.com/lxc/lxc/issues/3183
> 
> Stoiko Ivanov (2):
>   update lxc to include fixes for cgroupv2 setups
>   apparmor: add rule for allowing remount of boot_id
> 
>  ...apparmor-Allow-ro-remount-of-boot_id.patch | 26 +++++++++++++++++++
>  debian/patches/series                         |  1 +
>  lxc                                           |  2 +-
>  3 files changed, 28 insertions(+), 1 deletion(-)
>  create mode 100644 debian/patches/pve/0004-apparmor-Allow-ro-remount-of-boot_id.patch
> 

2/2 got merged into upstream and is available with 4.0.4, could you see
if we can seamlessly update from currently packaged 4.0.3 to 4.0.4?





      parent reply	other threads:[~2020-09-09 19:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-22 11:05 Stoiko Ivanov
2020-07-22 11:05 ` [pve-devel] [PATCH lxc 1/2] update lxc to include fixes for cgroupv2 setups Stoiko Ivanov
2020-07-22 11:05 ` [pve-devel] [PATCH lxc 2/2] apparmor: add rule for allowing remount of boot_id Stoiko Ivanov
2020-07-22 11:51   ` Thomas Lamprecht
2020-07-22 11:59     ` Stoiko Ivanov
2020-07-22 12:09       ` Thomas Lamprecht
2020-07-22 12:15         ` Stoiko Ivanov
2020-09-09 19:06 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c556ac5b-e501-7918-441c-5d4c735f6814@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.ivanov@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal