From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lukas Wagner <l.wagner@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH manager 1/2] fix #5067: vzdump: include total backup size in notification
Date: Mon, 29 Jan 2024 10:38:27 +0100 [thread overview]
Message-ID: <c51cf2e7-f1e8-4632-800a-6573956fc316@proxmox.com> (raw)
In-Reply-To: <20231214141154.279100-1-l.wagner@proxmox.com>
Am 14.12.23 um 15:11 schrieb Lukas Wagner:
> The old backup job notification mails from before the notification
> system overhaul included the total time as well as the total size.
>
> The total size was missing from the new, template-based backup report,
> thus we add it back in this commit.
>
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
applied series, thanks!
> PVE/VZDump.pm | 24 ++++++++++++++----------
> 1 file changed, 14 insertions(+), 10 deletions(-)
>
> diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
> index 4185ed62..91f60418 100644
> --- a/PVE/VZDump.pm
> +++ b/PVE/VZDump.pm
> @@ -414,15 +414,17 @@ sub sanitize_task_list {
> }
> }
>
> -sub count_failed_tasks {
> +my sub aggregate_task_statistics {
> my ($tasklist) = @_;
>
> my $error_count = 0;
> + my $total_size = 0;
> for my $task (@$tasklist) {
> $error_count++ if $task->{state} ne 'ok';
> + $total_size += $task->{size} if $task->{state} eq 'ok';
> }
>
> - return $error_count;
> + return $error_count, $total_size;
> }
With a small style fix to use parentheses for the list return here.
prev parent reply other threads:[~2024-01-29 9:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-14 14:11 [pve-devel] " Lukas Wagner
2023-12-14 14:11 ` [pve-devel] [PATCH manager 2/2] vzdump: make helper functions for sending notifications private Lukas Wagner
2024-01-08 10:44 ` [pve-devel] [PATCH manager 1/2] fix #5067: vzdump: include total backup size in notification Lukas Wagner
2024-01-29 9:38 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c51cf2e7-f1e8-4632-800a-6573956fc316@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox