From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Daniel Kral <d.kral@proxmox.com>
Subject: [pve-devel] applied-series: [PATCH manager 1/4] ui: api token: remove record context from TokenView add button handler
Date: Mon, 11 Nov 2024 18:50:18 +0100 [thread overview]
Message-ID: <c507608a-1f20-471e-8143-5851b2ba8306@proxmox.com> (raw)
In-Reply-To: <20241031134629.144893-1-d.kral@proxmox.com>
Am 31.10.24 um 14:46 schrieb Daniel Kral:
> Removes the record ("rec") variable from the TokenView, as it is always
> undefined, because the "Add" button is a ExtJS Button and therefore the
> button handler doesn't pass a third parameter as ProxmoxButton does.
>
> Signed-off-by: Daniel Kral <d.kral@proxmox.com>
> ---
> Please correct me if I'm missing something here, but I tested this
> through Firefox's JavaScript debugger and assumed that tbar items are
> "ExtJS.button.Button" by default, except when specifing another xtype.
>
> This will make the fix for #5722 clearer to implement.
>
> www/manager6/dc/TokenView.js | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
>
applied series with Fabian's T-b, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-11 17:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-31 13:46 [pve-devel] " Daniel Kral
2024-10-31 13:46 ` [pve-devel] [PATCH manager 2/4] ui: api token: remove unused fixed user property Daniel Kral
2024-10-31 13:46 ` [pve-devel] [PATCH manager 3/4] fix #5722: ui: api token: allow unprivileged users to create their own api tokens Daniel Kral
2024-10-31 13:46 ` [pve-devel] [PATCH manager 4/4] ui: api token: allow unprivileged users to modify " Daniel Kral
2024-11-05 8:14 ` [pve-devel] [PATCH manager 1/4] ui: api token: remove record context from TokenView add button handler Fabian Grünbichler
2024-11-11 17:50 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c507608a-1f20-471e-8143-5851b2ba8306@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.kral@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox