public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pve-devel] [PATCH installer 1/2] tui: wrap multi-disk selection in scrollable view
Date: Thu, 22 Jun 2023 14:45:54 +0200	[thread overview]
Message-ID: <c4ed17cd-17e4-5e8e-4856-f3ae03d04bf3@proxmox.com> (raw)
In-Reply-To: <20230622095617.671605-2-c.heiss@proxmox.com>

Am 22/06/2023 um 11:56 schrieb Christoph Heiss:
> If lots of disks are present and the available screen size is rather
> small, it might be impossible for users to properly set all disks as
> they want.
> 
> Fix it by making the view scrollable.
> 

what I forgot to write: It's much better than nothing if one has many disks, but the
selection behavior and scrolling interacts a bit weirdly IMO, i.e., something like:

- if I first move down the disk selection gets moved down, scrollbar stays as is
- if the selection goes over the view border the scroll bar moves but I see no
  selection any more
- once I then reached the end of the whole view (scrolled to bottom) the selection
  starts moving down again, but depending on how many disks entries there are it
  requires quite a few moves until it's in view again.

It would be more like expected if the selection moves along when scrolling down,
and up if scrolling up, respectively.






  parent reply	other threads:[~2023-06-22 12:45 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-22  9:56 [pve-devel] [PATCH installer 0/2] tui: make multi-disk selection view scrollable Christoph Heiss
2023-06-22  9:56 ` [pve-devel] [PATCH installer 1/2] tui: wrap multi-disk selection in scrollable view Christoph Heiss
2023-06-22 12:41   ` [pve-devel] applied: " Thomas Lamprecht
2023-06-22 12:45   ` Thomas Lamprecht [this message]
2023-06-22  9:56 ` [pve-devel] [PATCH installer 2/2] tui: disable automatic text wrapping for form labels Christoph Heiss
2023-06-22 12:41   ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4ed17cd-17e4-5e8e-4856-f3ae03d04bf3@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal