From: Fiona Ebner <f.ebner@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Friedrich Weber <f.weber@proxmox.com>
Subject: [pve-devel] applied: [PATCH manager] ui: qemu: hardware: fix permission check for adding tpmstate volume
Date: Tue, 10 Sep 2024 12:27:08 +0200 [thread overview]
Message-ID: <c4cb45ec-fcef-4e6d-80cd-d938f1c09132@proxmox.com> (raw)
In-Reply-To: <20240805133337.12188-1-f.weber@proxmox.com>
Am 05.08.24 um 15:33 schrieb Friedrich Weber:
> Previously, the "Add -> TPM State" menu item in the GUI was disabled
> if the user did not have Sys.Console privileges. This deviated from
> the permission check in the backend, which does not require
> Sys.Console but (among others) VM.Config.Disk.
>
> Fix this inconsistency by checking for VM.Config.Disk in the frontend
> instead of Sys.Console.
>
> Reported in enterprise support.
>
> Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
applied, thanks!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-09-10 10:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 13:33 [pve-devel] " Friedrich Weber
2024-09-10 10:27 ` Fiona Ebner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c4cb45ec-fcef-4e6d-80cd-d938f1c09132@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox