public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
	Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH v2 common] tools: file_set_contents: use syswrite instead of print
Date: Mon, 14 Oct 2024 11:22:12 +0200	[thread overview]
Message-ID: <c4c12a99-f72d-4a55-bd3d-b908214bd84d@proxmox.com> (raw)
In-Reply-To: <a4c5e7ba-f85c-4ed6-b25e-38851d7a476e@proxmox.com>

Am 14/10/2024 um 11:07 schrieb Dominik Csapak:
> hi since you applied this, we probably also want to apply the pmxcfs patch?

This is already an improvement on its own independent of where the destination
resides on, but yes, the pmxcfs one would have been the next to (re-)look more
closely at.

> (since without that, this patch does not really have an effect)
> 
> should i send a new version (as non rfc) with a better commit message for that
> or is that not necessary from your POV ?

Yes, please. It would be great if you could include some more background that
we learned since original submission and maybe some benchmarks directly, or at
least point to the one from Filip's commit.
But, as always, I'm a fan of keeping the essentials in the commit message
directly to make it more self-contained.




_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2024-10-14  9:21 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-09-30 11:40 [pve-devel] " Filip Schauer
2024-10-14  8:42 ` [pve-devel] applied: " Thomas Lamprecht
2024-10-14  9:07   ` Dominik Csapak
2024-10-14  9:22     ` Thomas Lamprecht [this message]
2024-10-14  9:26 ` [pve-devel] " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4c12a99-f72d-4a55-bd3d-b908214bd84d@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal