public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Friedrich Weber <f.weber@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Markus Frank <m.frank@proxmox.com>
Subject: Re: [pve-devel] [PATCH docs v5 5/5] added noVNC clipboard documentation
Date: Fri, 14 Apr 2023 13:08:16 +0200	[thread overview]
Message-ID: <c4a0952b-462b-af8f-17e9-4e4e5460ef0f@proxmox.com> (raw)
In-Reply-To: <20230412085731.25183-6-m.frank@proxmox.com>

I tested this (also discussed off-list, posting here for the record):

Creating a new VM with the default display (no `vga` config entry),
then enabling the "Use noVNC clipboard" option via the Web UI results in
a "vga type is not compatible with clipboard (500)" error. It works if I
explicitly set the display to Standard VGA first.

After that and after installing spice-vdgent in the guest, I can use the
noVNC console to control the guest keyboard -- nice!

Below, my 2 cents regarding docs/naming/GUI:

On 12/04/2023 10:57, Markus Frank wrote:
> +In order to use the clipboard feature, you must first install the
> +spice guest tools. On Debian-based distributions, this can be achieved
> +by installing `spice-vdagent`.

I was initially confused where to install the SPICE tools (but that
might just be me).

Maybe we could also include a link to the SPICE guest tools here?

Nit: "spice" guest tools should probably be "SPICE" guest tools

> +Once you have installed the spice guest tools, you can use the clipboard
> +function in the noVNC console.

For me it wasn't immediately clear what the clipboard function is -- now
I understand it is the additional button in the collapsible sidebar of
the noVNC window. Maybe we could have a few extra words here to make
that clearer?

> However, if you're using SPICE, virtio or virgl,
> +you'll need to choose which clipboard to use. This is because the
> +default *SPICE* clipboard will be replaced by the *noVNC* clipboard,
> +if `clipboard` is set to 1.

To me, `clipboard` sounds like a rather general option not tied to a
specific display driver, but if I understand correctly, `clipboard=1`
actually means "use the noVNC clipboard". I wonder if it would be better
to have an option name that specifically refers to noVNC?

One last thing regarding GUI: I do understand the reasoning for putting
the checkbox to "Options" -- but I do find it a bit counterintuitive
that the Hardware->Display entry now reads "Standard VGA
(std,clipboard=1)" even though I cannot change the `clipboard` setting
by double-clicking the entry. But also here, that might just me.




      reply	other threads:[~2023-04-14 11:08 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-12  8:57 [pve-devel] [PATCH qemu-server/manager/novnc/docs v5 0/5] Feature noVNC-Clipboard Markus Frank
2023-04-12  8:57 ` [pve-devel] [PATCH qemu-server v5 1/5] enable clipboard parameter in vga_fmt Markus Frank
2023-04-12  8:57 ` [pve-devel] [PATCH qemu-server v5 2/5] test cases for clipboard spice & std Markus Frank
2023-04-12  8:57 ` [pve-devel] [PATCH novnc v5 3/5] added show clipboard button patch to series Markus Frank
2023-04-12  8:57 ` [pve-devel] [PATCH manager v5 4/5] added clipboard checkbox to VM Options Markus Frank
2023-04-12  8:57 ` [pve-devel] [PATCH docs v5 5/5] added noVNC clipboard documentation Markus Frank
2023-04-14 11:08   ` Friedrich Weber [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c4a0952b-462b-af8f-17e9-4e4e5460ef0f@proxmox.com \
    --to=f.weber@proxmox.com \
    --cc=m.frank@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal