Re: [pve-devel] [PATCH V2 qemu-server 0/2] add virtio-mem support

["DERUMIER, Alexandre" <Alexandre.DERUMIER@groupe-cyllene.com>]

Hi,

does somebody had time to review this patch series ?

Does I need to rework it ? Any commment ?

Regards,

Alexandre


Le mercredi 24 août 2022 à 13:34 +0200, Alexandre Derumier a écrit :
> This patch add virtio-mem support, through a new maxmemory option.
> 
> a 4GB static memory is needed for DMA+boot memory, as this memory
> is almost always un-unpluggeable.
> 
> 1 virtio-mem pci device is setup for each numa node on pci.4 bridge
> 
> virtio-mem use a fixed blocksize with 32k max blocksize,
> so blocksize is computed from the maxmemory/32000 with a minimum of
> 2MB to map THP.
> (lower blocksize = more chance to unplug memory).
> 
> guests tested:
> - ubuntu 22.04 : kernel 5.15 : works out of the box
> - debian11: kernel 5.10 : don't display new memory value
> 
> more info about virtio-mem:
> https://antiphishing.cetsi.fr/proxy/v3?i=RTNLd2NGeE1RTDFrR25iaMqX4l6Z4vdhOnd7odh9trs&r=ZnVkMm1UMHFmWHNzejI1TlfXqTIFgoT3RRT8SRpkUCzNU_sadVHVE4gmJHKxU2tEI-v-lvK2LprrEOT08up8vw&f=UU1XcHkxazJBTmIySlBBMWR_zLcv5a0_cIOSeWbIK2KapikXx8zXaPqWjlzjA2kV1Dznkr2dclNPHmvBavMw9A&u=https%3A//virtio-mem.gitlab.io/&k=ywmE
> 
> 
> Changelog v2:
> 
> - Allow only multiple of 32MB for memory. With lower values, guest
> sometimes
>   hang.  I have tested with step of 32MB from 4G to 768G, it's
> working fine.
> 
> - rebase tests
> 
> Alexandre Derumier (2):
>   add virtio-mem support
>   tests: add virtio-mem tests
> 
>  PVE/QemuServer.pm                           |   9 +-
>  PVE/QemuServer/Memory.pm                    | 133 +++++++++++++++---
> --
>  PVE/QemuServer/PCI.pm                       |   8 ++
>  test/cfg2cmd/simple-virtio-mem-big.conf     |  12 ++
>  test/cfg2cmd/simple-virtio-mem-big.conf.cmd |  59 +++++++++
>  test/cfg2cmd/simple-virtio-mem.conf         |  13 ++
>  test/cfg2cmd/simple-virtio-mem.conf.cmd     |  31 +++++
>  7 files changed, 236 insertions(+), 29 deletions(-)
>  create mode 100644 test/cfg2cmd/simple-virtio-mem-big.conf
>  create mode 100644 test/cfg2cmd/simple-virtio-mem-big.conf.cmd
>  create mode 100644 test/cfg2cmd/simple-virtio-mem.conf
>  create mode 100644 test/cfg2cmd/simple-virtio-mem.conf.cmd
>