From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer] fetch-answer, post-hook: rename $format-info to $schema
Date: Sun, 17 Nov 2024 16:05:01 +0100 [thread overview]
Message-ID: <c3ee1b69-4d00-4f16-aac7-b3b825ac4d3a@proxmox.com> (raw)
In-Reply-To: <20241115163000.1189086-1-c.heiss@proxmox.com>
Am 15.11.24 um 17:28 schrieb Christoph Heiss:
> 'schema' describes the purpose the of this object better and is a more
> "industry-standard" term.
>
> Changes it for both locations where we currently have such an object.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> No hard feelings though if stay with $format-info if that is indeed
> preferred.
tbh. I avoided it as I wasn't 100% sure if you decided explicitly against
that and I did not want to clash with anything from JSON schema, but it
probably is the better choice, and now it's still easy to change.
>
> proxmox-fetch-answer/src/fetch_plugins/http.rs | 14 +++++++-------
> proxmox-post-hook/src/main.rs | 14 +++++++-------
> 2 files changed, 14 insertions(+), 14 deletions(-)
>
>
applied, thanks! Please remember to update docs accordingly.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-17 15:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-15 16:28 [pve-devel] " Christoph Heiss
2024-11-17 15:05 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c3ee1b69-4d00-4f16-aac7-b3b825ac4d3a@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox