public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Christoph Heiss <c.heiss@proxmox.com>
Subject: [pve-devel] applied: [PATCH installer] proxinstall: replace usage of hacky `mngmt_nic_id` config option
Date: Fri, 4 Apr 2025 10:33:55 +0200	[thread overview]
Message-ID: <c33e36c5-6b9f-4c7f-b8b3-b859f6260af1@proxmox.com> (raw)
In-Reply-To: <20250324132000.770784-2-c.heiss@proxmox.com>

Am 24.03.25 um 14:19 schrieb Christoph Heiss:
> The option was more or less a hack from the beginning anyway, introduced
> during the split of the GUI and the installation configuration.
> 
> The required information is already there from `mngmt_nic` - which
> carries the name of the network interface - and is easily reused to
> replace the functionality.
> 
> In short, the `mngmt_nic_id` setting was only used to check whether
> another NIC was selected, avoiding needless updates to the IP address
> and mask textboxes.
> 
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
>  Proxmox/Install/Config.pm | 6 ------
>  proxinstall               | 9 ++++-----
>  2 files changed, 4 insertions(+), 11 deletions(-)
> 
>

applied, thanks! lets see if anything subtle breaks ^^


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2025-04-04  8:34 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-03-24 13:19 [pve-devel] " Christoph Heiss
2025-04-04  8:33 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c33e36c5-6b9f-4c7f-b8b3-b859f6260af1@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=c.heiss@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal