From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pve-devel] [PATCH ve-rs 1/2] fix: firewall: introduce iptables to nftables mapping for icmpv6-types
Date: Sat, 4 Oct 2025 15:17:30 +0200 [thread overview]
Message-ID: <c2da3a30-93c8-4d76-917f-814fab9c9173@proxmox.com> (raw)
In-Reply-To: <20250916093116.114942-2-g.goller@proxmox.com>
Am 16.09.25 um 11:32 schrieb Gabriel Goller:
> + if let Ok(index) = IPTABLES_ICMP_TYPES_MAPPING.binary_search_by(|v| v.0.cmp(s)) {
> + if let Some(mapped_nftables_type) = IPTABLES_ICMP_TYPES_MAPPING[index].1 {
> + return Ok(Self::Named(mapped_nftables_type));
> + } else {
> + bail!("icmp_type {s:?} is unsupported in nftables");
How is this Err handled on use sites? As for the bail below I'd be fine
if it causes some further failure down the road, but if it is a supported
type in pve-firewall above should not cause any actual error or rule
generations to get skipped, besides skipping the nftables-unsupported
ones, obviously.
Also, the linked wiki spots "Last update: Mar/2022" at the top, so a bit
dated. Did you actually try if this is still the case for all of the
listed ones?
> + }
> + }
> +
> bail!("{s:?} is not a valid icmpv6 type");
> }
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-10-04 13:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-16 9:31 [pve-devel] [PATCH proxmox-firewall/ve-rs 0/3] Fix ICMPv6 types in nftables Gabriel Goller
2025-09-16 9:31 ` [pve-devel] [PATCH ve-rs 1/2] fix: firewall: introduce iptables to nftables mapping for icmpv6-types Gabriel Goller
2025-10-01 16:46 ` Stefan Hanreich
2025-10-04 13:17 ` Thomas Lamprecht [this message]
2025-09-16 9:31 ` [pve-devel] [PATCH ve-rs 2/2] firewall: correctly return errors when parsing icmpv6 types and codes Gabriel Goller
2025-09-16 9:31 ` [pve-devel] [PATCH proxmox-firewall 1/1] tests: add icmpv6 type mapping test Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c2da3a30-93c8-4d76-917f-814fab9c9173@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox