public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Filip Schauer <f.schauer@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH manager v16 10/12] ui: add resource mapping view for directories
Date: Mon, 7 Apr 2025 11:51:26 +0200	[thread overview]
Message-ID: <c2a7570c-fcb1-42b0-adf8-9d4eea93d5fa@proxmox.com> (raw)
In-Reply-To: <20250404160847.489922-11-m.frank@proxmox.com>

On 04/04/2025 18:08, Markus Frank wrote:
> diff --git a/www/manager6/dc/Config.js b/www/manager6/dc/Config.js
> index 74728c83..2958fb88 100644
> --- a/www/manager6/dc/Config.js
> +++ b/www/manager6/dc/Config.js
> @@ -329,6 +329,16 @@  Ext.define('PVE.dc.Config', {
>   			    title: gettext('USB Devices'),
>   			    flex: 1,
>   			},
> + {
> + xtype: 'splitter',
> + collapsible: false,
> + performCollapse: false,
> + },
> + {
> + xtype: 'pveDcDirMapView',
> + title: gettext('Directories'),
> + flex: 1,
> + },
>   		    ],
>   		},
>   	    );

Using a tabpanel here would reduce clutter on smaller screens.

          me.items.push(
          {
-            xtype: 'container',
+            xtype: 'tabpanel',
              onlineHelp: 'resource_mapping',
              title: gettext('Resource Mappings'),
              itemId: 'resources',
              iconCls: 'fa fa-folder-o',
-            layout: {
-            type: 'vbox',
-            align: 'stretch',
-            multi: true,
-            },
-            scrollable: true,
-            defaults: {
-            border: false,
-            },
              items: [
              {
                  xtype: 'pveDcPCIMapView',
                  title: gettext('PCI Devices'),
-                flex: 1,
-            },
-            {
-                xtype: 'splitter',
-                collapsible: false,
-                performCollapse: false,
+                itemId: 'pci-map',
              },
              {
                  xtype: 'pveDcUSBMapView',
                  title: gettext('USB Devices'),
-                flex: 1,
-            },
-            {
-                xtype: 'splitter',
-                collapsible: false,
-                performCollapse: false,
+                itemId: 'usb-map',
              },
              {
                  xtype: 'pveDcDirMapView',
                  title: gettext('Directories'),
-                flex: 1,
+                itemId: 'dir-map',
              },
              ],
          },



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

  reply	other threads:[~2025-04-07  9:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-04 16:08 [pve-devel] [PATCH cluster/guest-common/docs/qemu-server/manager v16 0/12] virtiofs Markus Frank
2025-04-04 16:08 ` [pve-devel] [PATCH cluster v16 1/12] add mapping/dir.cfg for resource mapping Markus Frank
2025-04-04 17:03   ` [pve-devel] applied: " Thomas Lamprecht
2025-04-04 16:08 ` [pve-devel] [PATCH guest-common v16 2/12] add dir mapping section config Markus Frank
2025-04-07  9:58   ` [pve-devel] applied: " Thomas Lamprecht
2025-04-04 16:08 ` [pve-devel] [PATCH docs v16 3/12] add doc section for the shared filesystem virtio-fs Markus Frank
2025-04-04 16:08 ` [pve-devel] [PATCH qemu-server v16 4/12] control: add virtiofsd as runtime dependency for qemu-server Markus Frank
2025-04-07 10:43   ` Thomas Lamprecht
2025-04-07 10:59     ` Markus Frank
2025-04-07 12:00       ` Thomas Lamprecht
2025-04-07 12:03         ` Markus Frank
2025-04-04 16:08 ` [pve-devel] [PATCH qemu-server v16 5/7] fix #1027: virtio-fs support Markus Frank
2025-04-04 16:08 ` [pve-devel] [PATCH qemu-server v16 6/12] migration: check_local_resources for virtiofs Markus Frank
2025-04-04 16:08 ` [pve-devel] [PATCH qemu-server v16 7/12] disable snapshot (with RAM) and hibernate with virtio-fs devices Markus Frank
2025-04-04 16:08 ` [pve-devel] [PATCH manager v16 08/12] api: add resource map api endpoints for directories Markus Frank
2025-04-04 16:08 ` [pve-devel] [PATCH manager v16 09/12] ui: add edit window for dir mappings Markus Frank
2025-04-04 16:08 ` [pve-devel] [PATCH manager v16 10/12] ui: add resource mapping view for directories Markus Frank
2025-04-07  9:51   ` Filip Schauer [this message]
2025-04-04 16:08 ` [pve-devel] [PATCH manager v16 11/12] ui: form: add selector for directory mappings Markus Frank
2025-04-04 16:08 ` [pve-devel] [PATCH manager v16 12/12] ui: add options to add virtio-fs to qemu config Markus Frank
2025-04-07 12:03   ` Filip Schauer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c2a7570c-fcb1-42b0-adf8-9d4eea93d5fa@proxmox.com \
    --to=f.schauer@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal