Re: [pve-devel] [PATCH ceph master 3/3] buildsys: add check for changed ceph-osd sysctl settings

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 15/02/2024 um 10:40 schrieb Friedrich Weber:
> If the ceph-osd sysctl settings template (30-ceph-osd.conf.in) shipped
> by upstream changes, our ceph-osd postinst patch will need to be
> adapted to apply the new settings on package upgrade. To make sure we
> do not forget, store the current checksum of that file in our Makefile
> and fail the build early if the checksums do not match.
> 
> Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
> ---
> 
> Notes:
>     - failing the build might be a bit drastic, but a simple warning seems
>       too easy to overlook
>     - strictly speaking we'll miss updates of `sysctl_pid_max` [1], but to
>       catch this, we'd need to check the generated 30-ceph-osd.conf
>       (without .in) after it is generated during the build process, and
>       failing then sounds may be too annoying :)
>     
>     [1] https://github.com/ceph/ceph/blob/main/etc/sysctl/90-ceph-osd.conf.in
> 

noticing is one thing, but then having an actual plan what to do is something
else, as most options would again have the possibility to override existing
sysctls. IMO just installing the new file is fine too, and judging from the
past this file won't see that much churn, especially during stable point
releases, so omitting this one for now, maybe checking out the bigger picture
(see reply to patch 1/3) leads to some improvements that make it really
obsolete anyway.