public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Fabian Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [RFC qemu-server] api: create disks: avoid adding secondary cloud-init drives
Date: Mon, 12 Sep 2022 18:06:10 +0200	[thread overview]
Message-ID: <c20a9933-f147-7685-bdd7-fae18f0189dc@proxmox.com> (raw)
In-Reply-To: <20220506101114.45522-1-f.ebner@proxmox.com>

Am 06/05/2022 um 12:11 schrieb Fabian Ebner:
> This will break possibly existing workflows like
> 1. add second cloud-init
> 2. remove first cloud-init
> to change the cloud-init storage.
> 
> On the other hand, it avoids unintended misconfiguration of having
> mutliple cloud-init drives with potentially different settings.
> 
> Also in preparation for adding cloud-init-related API calls, where
> not being able to assume that there's only one cloud-init drive/state
> would complicate things quite a bit.
> 
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> 
> Are there any scenarios where having multiple cloud-init drives is
> useful?
> 
>  PVE/API2/Qemu.pm  | 19 +++++++++++++++++++
>  PVE/QemuConfig.pm | 15 +++++++++++++++
>  2 files changed, 34 insertions(+)
> 
>

applied, thanks!




      parent reply	other threads:[~2022-09-12 16:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-06 10:11 [pve-devel] " Fabian Ebner
2022-05-16  8:32 ` DERUMIER, Alexandre
2022-07-04  8:54   ` Mira Limbeck
2022-05-16 11:04 ` DERUMIER, Alexandre
2022-07-04  8:57   ` Mira Limbeck
2022-07-04  7:44 ` Fabian Ebner
2022-09-12 16:06 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c20a9933-f147-7685-bdd7-fae18f0189dc@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.ebner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal