Re: [PATCH pve-manager v3 15/17] ui: sdn: add zone DHCP backend selector and subnet DHCP options

[Stefan Hanreich <s.hanreich@proxmox.com>]

Reviewed-by: Stefan Hanreich <s.hanreich@proxmox.com>
Tested-by: Stefan Hanreich <s.hanreich@proxmox.com>

On 10/20/26 10:02 AM, Hannes Laimer wrote:
> Zones of every type can now get DHCP from the eBPF backend, while
> dnsmasq stays limited to simple zones. The checkbox that enabled
> dnsmasq on simple zones becomes a backend selector in the advanced
> options of every zone dialog.
> 
> The subnet dialog gains fields for the new DHCP lease time and for the
> DHCP DNS server, which could be set only through the API until now.
> The eBPF backend hands out a DNS server only when the subnet sets one.
> 
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
>  www/manager6/sdn/SubnetEdit.js       | 23 +++++++++++++++++++++++
>  www/manager6/sdn/zones/Base.js       | 17 +++++++++++++++++
>  www/manager6/sdn/zones/SimpleEdit.js | 11 -----------
>  3 files changed, 40 insertions(+), 11 deletions(-)
> 
> diff --git a/www/manager6/sdn/SubnetEdit.js b/www/manager6/sdn/SubnetEdit.js
> index a3608428..a1d36eeb 100644
> --- a/www/manager6/sdn/SubnetEdit.js
> +++ b/www/manager6/sdn/SubnetEdit.js
> @@ -56,6 +56,29 @@ Ext.define('PVE.sdn.SubnetInputPanel', {
>                  deleteEmpty: '{!isCreate}',
>              },
>          },
> +        {
> +            xtype: 'proxmoxtextfield',
> +            name: 'dhcp-dns-server',
> +            vtype: 'IP64Address',
> +            fieldLabel: gettext('DHCP DNS Server'),
> +            allowBlank: true,
> +            skipEmptyText: true,
> +            cbind: {
> +                deleteEmpty: '{!isCreate}',
> +            },
> +        },
> +        {
> +            xtype: 'proxmoxintegerfield',
> +            name: 'dhcp-lease-time',
> +            fieldLabel: gettext('DHCP Lease Time') + ' (s)',
> +            emptyText: Proxmox.Utils.defaultText,
> +            minValue: 60,
> +            maxValue: 4294967295,
> +            allowBlank: true,
> +            cbind: {
> +                deleteEmpty: '{!isCreate}',
> +            },
> +        },
>      ],
>  });
>  
> diff --git a/www/manager6/sdn/zones/Base.js b/www/manager6/sdn/zones/Base.js
> index 66f93de0..7696136d 100644
> --- a/www/manager6/sdn/zones/Base.js
> +++ b/www/manager6/sdn/zones/Base.js
> @@ -82,6 +82,23 @@ Ext.define('PVE.panel.SDNZoneBase', {
>              },
>          );
>  
> +        let dhcpBackends = [
> +            ['__default__', Proxmox.Utils.NoneText],
> +            ['ebpf', 'eBPF'],
> +        ];
> +        if (me.type === 'simple') {
> +            dhcpBackends.splice(1, 0, ['dnsmasq', 'dnsmasq']);
> +        }
> +
> +        me.advancedItems.push({
> +            xtype: 'proxmoxKVComboBox',
> +            name: 'dhcp',
> +            fieldLabel: gettext('DHCP Backend'),
> +            comboItems: dhcpBackends,
> +            value: '__default__',
> +            deleteEmpty: !me.isCreate,
> +        });
> +
>          me.callParent();
>      },
>  });
> diff --git a/www/manager6/sdn/zones/SimpleEdit.js b/www/manager6/sdn/zones/SimpleEdit.js
> index ba10bb36..aeb076ae 100644
> --- a/www/manager6/sdn/zones/SimpleEdit.js
> +++ b/www/manager6/sdn/zones/SimpleEdit.js
> @@ -19,17 +19,6 @@ Ext.define('PVE.sdn.zones.SimpleInputPanel', {
>          var me = this;
>  
>          me.items = [];
> -        me.advancedItems = [
> -            {
> -                xtype: 'proxmoxcheckbox',
> -                name: 'dhcp',
> -                inputValue: 'dnsmasq',
> -                uncheckedValue: null,
> -                checked: false,
> -                fieldLabel: gettext('Automatic DHCP'),
> -                deleteEmpty: !me.isCreate,
> -            },
> -        ];
>  
>          me.callParent();
>      },