From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Fiona Ebner <f.ebner@proxmox.com>
Subject: [pve-devel] applied: [PATCH v3 qemu] init: daemonize: defuse PID file resolve error
Date: Fri, 28 Oct 2022 10:59:08 +0200 [thread overview]
Message-ID: <c192a92d-cb3c-f31c-de56-39e701aca787@proxmox.com> (raw)
In-Reply-To: <20221028080946.29238-1-f.ebner@proxmox.com>
On 28/10/2022 10:09, Fiona Ebner wrote:
> When proxmox-file-restore invokes QEMU, the PID file is a (temporary)
> file that's already unlinked, so resolving the absolute path here
> failed.
>
> It should not be a critical error when the PID file unlink handler
> can't be registered, because the path can't be resolved for whatever
> reason. If the file is already gone from QEMU's perspective (i.e.
> errno is ENOENT), silently ignore the error. Otherwise, print a
> warning.
>
> Reported-by: Dominik Csapak <d.csapak@proxmox.com>
> Suggested-by: Thomas Lamprecht <t.lamprecht@proxmox.com>
> Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
> ---
>
> Changes from v2:
> * Be quiet when error is ENOENT.
>
> softmmu/vl.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2022-10-28 8:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-28 8:09 [pve-devel] " Fiona Ebner
2022-10-28 8:59 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c192a92d-cb3c-f31c-de56-39e701aca787@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox