public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Philipp Hufnagl" <p.hufnagl@proxmox.com>,
	"Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v8 1/2] fix #4849: api: download to storage: automatically dectect and configure compression
Date: Tue, 26 Sep 2023 16:23:41 +0200	[thread overview]
Message-ID: <c170e593-8998-4a41-8344-38528062ffb4@proxmox.com> (raw)
In-Reply-To: <be63bea0-8beb-e695-7683-43dd770eb415@proxmox.com>

Am 26/09/2023 um 14:25 schrieb Philipp Hufnagl:
> On 9/26/23 12:56, Thomas Lamprecht wrote:
>> while this is already applied, some comments inline, for a possible next
>> time, and also the big
>> question if this is even required, after all I can just check the few
>> compression algorithms easily in the frontend, i.e., offloading a simple
>> string regex match to the backend seems rather odd to me..
> The problem with that is that the point where the iso is stored might
> not be accessible for the client. If it is done by the PVE, it might
> resolve the url differently.

I'm not sure if I understand, I thought that's why we made the link
metadata- query API in the first place (which I obv. do not want to drop
in general)?

As we got the correct (from the PVE node's POV) resolved filename
returned by the metadata query API, so we can just do the regex string
match for detecting a possible compression file extension on that in the
frontend after that API call returns.





  reply	other threads:[~2023-09-26 14:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-21 13:09 [pve-devel] [PATCH manager v8 0/2] fix #4849: allow download of compressed ISOs Philipp Hufnagl
2023-09-21 13:09 ` [pve-devel] [PATCH manager v8 1/2] fix #4849: api: download to storage: automatically dectect and configure compression Philipp Hufnagl
2023-09-26 10:56   ` Thomas Lamprecht
2023-09-26 12:25     ` Philipp Hufnagl
2023-09-26 14:23       ` Thomas Lamprecht [this message]
2023-09-26 14:54         ` Philipp Hufnagl
2023-09-26 14:57           ` Thomas Lamprecht
2023-09-27  8:03     ` Philipp Hufnagl
2023-09-27  8:33       ` Thomas Lamprecht
2023-09-27  8:57         ` Philipp Hufnagl
2023-09-27 17:19           ` Thomas Lamprecht
2023-09-21 13:09 ` [pve-devel] [PATCH manager v8 2/2] fix #4849: ui: " Philipp Hufnagl
2023-09-26 10:59   ` Thomas Lamprecht
2023-09-26 12:27     ` Philipp Hufnagl
2023-09-22 14:02 ` [pve-devel] [PATCH manager v8 0/2] fix #4849: allow download of compressed ISOs Dominik Csapak
2023-09-26  7:39 ` [pve-devel] applied-series: [PATCH manager v9 " Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c170e593-8998-4a41-8344-38528062ffb4@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=f.gruenbichler@proxmox.com \
    --cc=p.hufnagl@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal