From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Stefan Hanreich <s.hanreich@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Gabriel Goller <g.goller@proxmox.com>
Subject: Re: [pve-devel] [PATCH network v2 1/5] sdn: add global lock for configuration
Date: Tue, 29 Jul 2025 10:21:01 +0200 [thread overview]
Message-ID: <c0c1cf2b-3028-4ffb-9767-75b8a795e7d6@proxmox.com> (raw)
In-Reply-To: <067c88b2-330a-49a2-96d9-064ed550d0ff@proxmox.com>
Am 29.07.25 um 09:59 schrieb Stefan Hanreich:
> On 7/29/25 9:28 AM, Thomas Lamprecht wrote:
>> nit: might be better to avoid the "secret" terminology here? As this is not really
>> a secret but rather something like a token, handle or maybe even cookie.
...
>> Could be fixed up though, if you agree with changing this and have an opinion
>> on what variant (handle, token, cookie, ...?) would be best.
>
> Makes sense, I'm gravitating towards token then - although handle would
> be fine by me as well. Cookie has the same issues with pre-existing
> sentiment / connotations imo?
While lock handle is common term, those handles more often refer to file
handles, so token might be indeed the least problematic / overloaded
term here.
> Gabriel mentioned something similar about the used characters, because
> the current character set is also inconvenient for running CLI commands.
> UUIDv7 sounds sensible for this use-case and since we already use the
> UUID module in our stack we could just opt for that?
ack.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-07-29 8:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-24 14:17 [pve-devel] [PATCH network v2 0/5] Add global locking and configuration rollback to SDN configuration Gabriel Goller
2025-07-24 14:17 ` [pve-devel] [PATCH network v2 1/5] sdn: add global lock for configuration Gabriel Goller
2025-07-29 7:27 ` Thomas Lamprecht
2025-07-29 7:59 ` Stefan Hanreich
2025-07-29 8:21 ` Thomas Lamprecht [this message]
2025-07-24 14:17 ` [pve-devel] [PATCH network v2 2/5] api: add lock-secret parameter to all api calls Gabriel Goller
2025-07-24 14:17 ` [pve-devel] [PATCH network v2 3/5] api: add lock secret parameter to apply endpoint Gabriel Goller
2025-07-24 14:17 ` [pve-devel] [PATCH network v2 4/5] api: add lock and release endpoints for global configuration lock Gabriel Goller
2025-07-24 14:17 ` [pve-devel] [PATCH network v2 5/5] api: add rollback endpoint Gabriel Goller
2025-07-29 9:30 ` [pve-devel] [PATCH network v2 0/5] Add global locking and configuration rollback to SDN configuration Gabriel Goller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c0c1cf2b-3028-4ffb-9767-75b8a795e7d6@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=g.goller@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox