From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Fabian Grünbichler" <f.gruenbichler@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] fix #4372: fix vm_resume migration callback
Date: Wed, 30 Nov 2022 16:22:49 +0100 [thread overview]
Message-ID: <c04f67ca-787e-5c9e-3506-54d9f5dd34bc@proxmox.com> (raw)
In-Reply-To: <20221129120926.1241594-1-f.gruenbichler@proxmox.com>
Am 29/11/2022 um 13:09 schrieb Fabian Grünbichler:
> the fix for the recently introduced requirement of loading the VM config while
> migrating was incomplete, since the vmlist node value could already be out of
> date by the time load_config is called.
>
> extend the fallback behaviour even further, by doing the following sequence:
> - try regular load_config (likely case, rename already fully processed)
> - if it fails, get node from vmlist, and load_config using that
> - it that fails, invalidate the PVE::Cluster cache, retry regular load_config
>
> Signed-off-by: Fabian Grünbichler <f.gruenbichler@proxmox.com>
> ---
>
> Notes:
> an alternative approach would be to do the fallback load first, and if that
> fails do the target node load. it has the downside of doing two loads in the
> "good"/likely case where the rename is processed before the resume call, while
> making the unlikely case (fallback needed) cheaper.
>
> PVE/QemuServer.pm | 16 +++++++++++-----
> 1 file changed, 11 insertions(+), 5 deletions(-)
>
>
applied, thanks!
prev parent reply other threads:[~2022-11-30 15:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-29 12:09 [pve-devel] " Fabian Grünbichler
2022-11-29 18:24 ` Fabian Grünbichler
2022-11-30 15:22 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c04f67ca-787e-5c9e-3506-54d9f5dd34bc@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.gruenbichler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox