From: Fabian Ebner <f.ebner@proxmox.com>
To: Aaron Lauterer <a.lauterer@proxmox.com>, pve-devel@lists.proxmox.com
Subject: [pve-devel] applied-series: [PATCH v2 manager 1/3] ui: rbd: cephfs: add keyring/secret field for external clusters
Date: Fri, 28 Jan 2022 12:23:01 +0100 [thread overview]
Message-ID: <c042e4cd-7a37-3472-9b9e-b19e8188dc28@proxmox.com> (raw)
In-Reply-To: <20220126101844.558040-1-a.lauterer@proxmox.com>
Am 26.01.22 um 11:18 schrieb Aaron Lauterer:
> Manual switching of xtype because binding 'hidden' does not work with
> pmxDisplayEditField.
>
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
> changes: added spaces in front of `?` operator that were missed.
>
>
> From previous iteration for this patch:
>
> Reviewed-by: Fabian Ebner <f.ebner@proxmox.com>
> Tested-by: Fabian Ebner <f.ebner@proxmox.com>
>
> www/manager6/storage/CephFSEdit.js | 39 ++++++++++++++++++++----------
> www/manager6/storage/RBDEdit.js | 11 +++++++++
> 2 files changed, 37 insertions(+), 13 deletions(-)
>
thanks! Added two small followups after a brief discussion with Thomas,
namely using gettext('Secret Key') for the field label for CephFS and
making the "is done automatically for local cluster" more obvious in the
docs. Also added the missing f in the second commit title again ;)
next prev parent reply other threads:[~2022-01-28 11:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-26 10:18 [pve-devel] " Aaron Lauterer
2022-01-26 10:18 ` [pve-devel] [PATCH v2 docs 2/3] storage: rbd: cephs: update authentication section Aaron Lauterer
2022-01-26 10:18 ` [pve-devel] [PATCH v2 docs 3/3] update Ceph codename and docs url to octopus Aaron Lauterer
2022-01-28 11:23 ` Fabian Ebner [this message]
2022-01-28 11:24 ` [pve-devel] applied-series: [PATCH v2 manager 1/3] ui: rbd: cephfs: add keyring/secret field for external clusters Aaron Lauterer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c042e4cd-7a37-3472-9b9e-b19e8188dc28@proxmox.com \
--to=f.ebner@proxmox.com \
--cc=a.lauterer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox