From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lorenz Stechauner <l.stechauner@proxmox.com>
Subject: [pve-devel] applied: Re: [PATCH v2 container] fix #3478: abort container creation on arch detection timeout
Date: Thu, 29 Jul 2021 17:51:43 +0200 [thread overview]
Message-ID: <c02d91fa-8ed9-923e-aa82-42248bcc9465@proxmox.com> (raw)
In-Reply-To: <20210722075456.112079-1-l.stechauner@proxmox.com>
On 22/07/2021 09:54, Lorenz Stechauner wrote:
> increased the timeout for detect_arch from 5 to 10 seconds.
>
> until now, on any error detect_architecture would fall back to amd64.
> to avoid falling back due to an timeout error this function now dies
> on timeout errors.
>
> additionally minor changes to the error messages have been made.
>
> Signed-off-by: Lorenz Stechauner <l.stechauner@proxmox.com>
> ---
> changes to v1:
> * implemented feedback
> * do not remove `\n` in error message
>
> src/PVE/LXC/Create.pm | 12 +++++++++---
> 1 file changed, 9 insertions(+), 3 deletions(-)
>
>
applied, thanks!
Albeit I find the "why" behind just sketchy, if opening /bin/sh and reading 20 bytes
from it cannot be done in 5s something is seriously off IMO, but well, now they at
least get an actual error to point at that fact.
prev parent reply other threads:[~2021-07-29 15:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-22 7:54 [pve-devel] " Lorenz Stechauner
2021-07-29 15:51 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c02d91fa-8ed9-923e-aa82-42248bcc9465@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.stechauner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox