public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "DERUMIER, Alexandre" <alexandre.derumier@groupe-cyllene.com>
To: "pve-devel@lists.proxmox.com" <pve-devel@lists.proxmox.com>,
	"d.csapak@proxmox.com" <d.csapak@proxmox.com>,
	"aderumier@odiso.com" <aderumier@odiso.com>
Subject: Re: [pve-devel] [PATCH pve-manager] qemu: bump max cores to 256 by socket
Date: Mon, 15 Jan 2024 12:43:20 +0000	[thread overview]
Message-ID: <c02c2de83fa93c2adae2ce28277e10da79fdea54.camel@groupe-cyllene.com> (raw)
In-Reply-To: <9c1ce32e-e54d-460d-81e4-8e4829853b24@proxmox.com>


>>mhmm.. in the backend we don't actually have a limit, maybe it's time
>>to remove the limit in the ui
>>altogether? it does not help anyway:

>>for numbers that are not too big (too many for qemu, too many for the
>>host)
>>it's not the right limit (qemu) or we don't know at that point in the
>>gui (host cores)

>>but in case next year there is e.g. a 512 core machine, the limit is
>>too low again...


>>so i'd be either for
>>* removing the limit at all
>>* limit to the qemu limits (but maybe also in the backend?)
>>* use the number of cores of the current host as limit in the gui
>>(should be possible, but an 
>>additional api call)
>>
>>what do you think?


Yes, indeed the backend don't have any limit.

We could indeed remove the limit in the gui.

I think we shouldn't limit based on the current host, as anyway, we can
create && migrate the vm on antoher host just after the create.


Maybe an improvement in qemu-server, could be to add additional check
at vm start, (maybe a simple warn), depending of qemu version or
setup. 
For example, 1024 cores only works with q35 && qemu 8.1,
it could be interesting to give an clean hint  mesage to user instead
a qemu process error.







  reply	other threads:[~2024-01-15 12:44 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-12 20:08 Alexandre Derumier
2024-01-15 11:46 ` Dominik Csapak
2024-01-15 12:43   ` DERUMIER, Alexandre [this message]
2024-01-15 13:08     ` Fiona Ebner
2024-01-16 14:08       ` DERUMIER, Alexandre
2024-01-16 15:20         ` Fiona Ebner
2024-02-20 12:50 ` [pve-devel] applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c02c2de83fa93c2adae2ce28277e10da79fdea54.camel@groupe-cyllene.com \
    --to=alexandre.derumier@groupe-cyllene.com \
    --cc=aderumier@odiso.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal