Re: [pve-devel] applied: [PATCH installer v4 0/6] fix #4829: wire up `arc_max` ZFS option to GUI/TUI for PVE

[Christoph Heiss <c.heiss@proxmox.com>]

On Tue, Nov 07, 2023 at 04:50:31PM +0100, Thomas Lamprecht wrote:
>
> Am 07/11/2023 um 13:20 schrieb Christoph Heiss:
> >   run env: remove debug print
> >   install: use correct variable names in zfs_setup_module_conf()
> >   proxinstall: expose `arc_max` ZFS option for PVE installations
> >   test: add tests for zfs_arc_max calculations
> >   common: add ZFS `arc_max` installer setup option
> >   tui: bootdisk: expose `arc_max` ZFS option for PVE installations
> >
>
> applied series, thanks!

Thanks!

>
> Two thoughts though:
>
> - we could add the ARC input field for PBS and PMG too, but not use the
>   automatic-sizing heuristic there (i.e., still 50% memory by default)

Makes sense, esp. for PBS due to its nature. I'll look into it sometime!

>
> - maybe GB with float would fit in better, but surely not perfect either,
>   so just for the record.

Good point, but I agree, hard to judge what's better. As we are
defaulting to max. 16 GiB (for PVE), it's a rather smaller range, so MiB
makes sense IMO.
Although aligning it with all the other inputs, which are in GiB, makes
sense too. As well as inputting it as GiB float should be precise enough
for any case.
I will definitely keep it in mind for the future.