public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Gabriel Goller <g.goller@proxmox.com>
To: Stefan Hanreich <s.hanreich@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH pve-manager 10/11] sdn: add fabric edit/delete forms
Date: Fri, 7 Mar 2025 17:04:58 +0100	[thread overview]
Message-ID: <bgnpdtcsbkmmnpyltaq5dls7qxq6vhdbg2cibaihh6z55ab7l6@k6osvpgsvpdb> (raw)
In-Reply-To: <eea3854b-c2a9-4037-8849-86896032fe50@proxmox.com>

>> diff --git a/www/manager6/sdn/fabrics/Common.js b/www/manager6/sdn/fabrics/Common.js
>> new file mode 100644
>> index 000000000000..72ec093fc928
>> --- /dev/null
>> +++ b/www/manager6/sdn/fabrics/Common.js
>> @@ -0,0 +1,222 @@
>> +Ext.define('PVE.sdn.Fabric.InterfacePanel', {
>> +    extend: 'Ext.grid.Panel',
>> +    mixins: ['Ext.form.field.Field'],
>> +
>> +    network_interfaces: undefined,
>> +
>> +    selectionChange: function(_grid, _selection) {
>> +	let me = this;
>> +	me.value = me.getSelection().map((rec) => {
>> +	    delete rec.data.cidr;
>> +	    delete rec.data.cidr6;
>> +	    delete rec.data.selected;
>> +	    return PVE.Parser.printPropertyString(rec.data);
>
>maybe we could explicitly select the fields we want to include here, so
>this doesn't break when we add new fields?

Depends on which fields :)
If we add fields to the interface, it won't break, if we add more
"display-only" fields it will break.

Anyway this is a common component, so we would need to pass/add a check for
the protocol and then select the protocol specific attributes.

>> +    updateSelectedInterfaces: function(values) {
>> +	let me = this;
>> +	if (values) {
>> +	    let recs = [];
>> +	    let store = me.getStore();
>> +
>> +	    for (const i of values) {
>> +		let rec = store.getById(i.name);
>> +		if (rec) {
>> +		    recs.push(rec);
>> +		}
>> +	    }
>> +	    me.suspendEvent('change');
>> +	    me.setSelection();
>> +	    me.setSelection(recs);
>> +	    me.resumeEvent('change');
>> +	} else {
>> +	    me.suspendEvent('change');
>> +	    me.setSelection();
>> +	    me.resumeEvent('change');
>> +	}
>
>could avoid some duplication by moving the methods calls above / below
>the if/else

I can extract the resumeEvent call, but keeping suspendEvent within each
branch is safer. If store operations fail between suspend and resume,
we'd risk permanently disabling the 'change' event listener.

Thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-03-07 16:05 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-14 13:39 [pve-devel] [RFC cluster/manager/network/proxmox{-ve-rs, -perl-rs} 00/11] Add SDN Fabrics Gabriel Goller
2025-02-14 13:39 ` [pve-devel] [PATCH proxmox-ve-rs 01/11] add crate with common network types Gabriel Goller
2025-03-03 15:08   ` Stefan Hanreich
2025-03-05  8:28     ` Gabriel Goller
2025-02-14 13:39 ` [pve-devel] [PATCH proxmox-ve-rs 02/11] add proxmox-frr crate with frr types Gabriel Goller
2025-03-03 16:29   ` Stefan Hanreich
2025-03-04 16:28     ` Gabriel Goller
2025-02-14 13:39 ` [pve-devel] [PATCH proxmox-ve-rs 03/11] add intermediate fabric representation Gabriel Goller
2025-02-28 13:57   ` Thomas Lamprecht
2025-02-28 16:19     ` Gabriel Goller
2025-03-04 17:30     ` Gabriel Goller
2025-03-05  9:03       ` Wolfgang Bumiller
2025-03-04  8:45   ` Stefan Hanreich
2025-03-05  9:09     ` Gabriel Goller
2025-02-14 13:39 ` [pve-devel] [PATCH proxmox-perl-rs 04/11] fabrics: add CRUD and generate fabrics methods Gabriel Goller
2025-03-04  9:28   ` Stefan Hanreich
2025-03-05 10:20     ` Gabriel Goller
2025-02-14 13:39 ` [pve-devel] [PATCH pve-cluster 05/11] cluster: add sdn fabrics config files Gabriel Goller
2025-02-28 12:19   ` Thomas Lamprecht
2025-02-28 12:52     ` Gabriel Goller
2025-02-14 13:39 ` [pve-devel] [PATCH pve-network 06/11] add config file and common read/write methods Gabriel Goller
2025-02-14 13:39 ` [pve-devel] [PATCH pve-network 07/11] merge the frr config with the fabrics frr config on apply Gabriel Goller
2025-02-14 13:39 ` [pve-devel] [PATCH pve-network 08/11] add api endpoints for fabrics Gabriel Goller
2025-03-04  9:51   ` Stefan Hanreich
2025-02-14 13:39 ` [pve-devel] [PATCH pve-manager 09/11] sdn: add Fabrics view Gabriel Goller
2025-03-04  9:57   ` Stefan Hanreich
2025-03-07 15:57     ` Gabriel Goller
2025-02-14 13:39 ` [pve-devel] [PATCH pve-manager 10/11] sdn: add fabric edit/delete forms Gabriel Goller
2025-03-04 10:07   ` Stefan Hanreich
2025-03-07 16:04     ` Gabriel Goller [this message]
2025-02-14 13:39 ` [pve-devel] [PATCH pve-manager 11/11] network: return loopback interface on network endpoint Gabriel Goller
2025-03-03 16:58 ` [pve-devel] [RFC cluster/manager/network/proxmox{-ve-rs, -perl-rs} 00/11] Add SDN Fabrics Stefan Hanreich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bgnpdtcsbkmmnpyltaq5dls7qxq6vhdbg2cibaihh6z55ab7l6@k6osvpgsvpdb \
    --to=g.goller@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.hanreich@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal