From: Hannes Laimer <h.laimer@proxmox.com>
To: Thomas Lamprecht <t.lamprecht@proxmox.com>, pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] applied: [PATCH proxmox-offline-mirror 0/2 RFC] allow key activation through URL
Date: Tue, 28 Oct 2025 10:40:24 +0100 [thread overview]
Message-ID: <bee092f4-4c49-4c99-a9e6-0d52cd13a5ab@proxmox.com> (raw)
In-Reply-To: <176159183010.4042839.3125682824913706238.b4-ty@proxmox.com>
On 10/27/25 20:05, Thomas Lamprecht wrote:
> On Fri, 17 Oct 2025 08:39:27 +0200, Hannes Laimer wrote:
>> If the medium is served over HTTP we can also load the `.mirror-state`
>> file over HTTP. This adds support for that.
>>
>> In case a http server is already setup, additionally requiring mounting
>> the medium directly anyway, at least for key activation, isn't
>> necesarry IMHO.
>>
>> [...]
>
> Applied with a bunch of follow-ups, some to improve your changes, but quite a
> few also to clean-up some bits of the status quo, which is why I finally choose
> to apply them on top over asking for a v2, as in the end that was simply less
> work for me. Would still appreciated if you could take another look at those
> clean ups. Thanks!
>
They LGTM, thanks!
> [1/2] helper: allow URL as source for offline key activation
> commit: 20c49dc8e01e4b2e03467100092093dc253f86c5
> [2/2] docs: add section for activating key over HTTP
> commit: 3d25be7a652f05e2c9203af0efd67eb503da6adf
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-10-28 9:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-17 6:39 [pve-devel] " Hannes Laimer
2025-10-17 6:39 ` [pve-devel] [PATCH proxmox-offline-mirror 1/2] helper: allow URL as source for offline key activation Hannes Laimer
2025-10-17 6:39 ` [pve-devel] [PATCH proxmox-offline-mirror 2/2] docs: add section for activating key over HTTP Hannes Laimer
2025-10-27 19:03 ` [pve-devel] applied: [PATCH proxmox-offline-mirror 0/2 RFC] allow key activation through URL Thomas Lamprecht
2025-10-28 9:40 ` Hannes Laimer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bee092f4-4c49-4c99-a9e6-0d52cd13a5ab@proxmox.com \
--to=h.laimer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox