From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Dominik Csapak <d.csapak@proxmox.com>
Subject: [pve-devel] applied: [PATCH docs] external metric server: update wording and add new info/screenshots
Date: Mon, 23 Nov 2020 13:37:15 +0100 [thread overview]
Message-ID: <bed121d6-b7b6-e08e-ad64-7ccbed45f821@proxmox.com> (raw)
In-Reply-To: <20201123110425.30087-1-d.csapak@proxmox.com>
On 23.11.20 12:04, Dominik Csapak wrote:
> drop the 'since 4.0' wording and the config editing part. instead
> mention the gui and add screenshots
>
> also mentions now the new options the plugins
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> .../gui-datacenter-metric-server-graphite.png | Bin 0 -> 15274 bytes
> .../gui-datacenter-metric-server-influxdb.png | Bin 0 -> 13332 bytes
> .../gui-datacenter-metric-server-list.png | Bin 0 -> 46346 bytes
> pve-external-metric-server.adoc | 58 ++++++------------
> 4 files changed, 18 insertions(+), 40 deletions(-)
> create mode 100644 images/screenshot/gui-datacenter-metric-server-graphite.png
> create mode 100644 images/screenshot/gui-datacenter-metric-server-influxdb.png
> create mode 100644 images/screenshot/gui-datacenter-metric-server-list.png
>
applied, thanks! Did a few style and grammar followups (an additional view wouldn't
hurt though @Dylan).
Also dropped the invisible white space which you noticed.
prev parent reply other threads:[~2020-11-23 12:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-23 11:04 [pve-devel] " Dominik Csapak
2020-11-23 11:04 ` [pve-devel] [PATCH manager] ui: add onlineHelp links for metric servers Dominik Csapak
2020-11-23 12:37 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bed121d6-b7b6-e08e-ad64-7ccbed45f821@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox