Re: [pve-devel] [PATCH cluster 2/3] add consent-text paramter to datacenter config file

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 03.12.24 um 16:29 schrieb Gabriel Goller:
> The consent-text paramter is the base64-encoded content of the optional
> consent-banner which can be displayed before login.

This can get quite big, would be good to set some relatively high limit here,
I think, as our pmxcfs files have a max size and not being able to change other
options due to this property being close to the pmxcfs file size limit would
not be ideal.

btw. Did we ever talk about placing this into a dedicated, separate file?
(just out of interest, might be also an option to consider here if we did
not talked already about it)

> 
> Signed-off-by: Gabriel Goller <g.goller@proxmox.com>
> ---
>  src/PVE/DataCenterConfig.pm | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/src/PVE/DataCenterConfig.pm b/src/PVE/DataCenterConfig.pm
> index abd0bbfd4532..0347bd5ae19f 100644
> --- a/src/PVE/DataCenterConfig.pm
> +++ b/src/PVE/DataCenterConfig.pm
> @@ -449,6 +449,11 @@ my $datacenter_schema = {
>  	    pattern => "(?:${PVE::JSONSchema::PVE_TAG_RE};)*${PVE::JSONSchema::PVE_TAG_RE}",
>  	    typetext => "<tag>[;<tag>...]",
>  	},
> +	'consent-text' => {
> +	    optional => 1,
> +	    type => 'string',
> +	    description => "Consent text that is displayed before logging in."
> +	},
>      },
>  };
>  



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel