From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Stefan Reiter <s.reiter@proxmox.com>
Subject: [pve-devel] applied: [PATCH common] format: fix render_bytes with CLIFormatter
Date: Thu, 25 Feb 2021 21:22:17 +0100 [thread overview]
Message-ID: <bcd910db-7008-228f-4057-1bfaa2030534@proxmox.com> (raw)
In-Reply-To: <20210217133216.2470-1-s.reiter@proxmox.com>
On 17.02.21 14:32, Stefan Reiter wrote:
> CLIFormatter passes in an options hash as a second paramter, which so
> far was ignored. Now that we treat it as a precision parameter, check if
> it is a hash and extract the option from it before using it.
>
> Otherwise perl puts HASH(0x...) into the format and sprintf chokes.
>
> Signed-off-by: Stefan Reiter <s.reiter@proxmox.com>
> ---
>
> Reported here: https://forum.proxmox.com/threads/bug-found-where-to-post.84407/
>
> I'm getting too used to Rust...
>
> src/PVE/Format.pm | 2 ++
> 1 file changed, 2 insertions(+)
>
>
applied, thanks!
prev parent reply other threads:[~2021-02-25 20:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-17 13:32 [pve-devel] " Stefan Reiter
2021-02-25 20:22 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcd910db-7008-228f-4057-1bfaa2030534@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.reiter@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox