From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Alexander Zeidler <a.zeidler@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 2/3] pvesubscription: update set-offline-key description
Date: Wed, 10 Jan 2024 10:41:05 +0100 [thread overview]
Message-ID: <bccb7187-575d-40ce-8b47-07f2511031eb@proxmox.com> (raw)
In-Reply-To: <20240109142356.171494-2-a.zeidler@proxmox.com>
Am 09/01/2024 um 15:23 schrieb Alexander Zeidler:
> and point users to proxmox-offline-mirror-helper
the change is fine, but having any background/reason/why here could be
still nice, I never saw a commit with to much references or reasons
state for why a change was done, and having those can definitively
help when looking at that in the future – as in contrast to the
"what/how it changed" (which basically is encoded in the diff itself)
this might not be recoverable in the future.
For any patches documenting the reason and background is most of
the time the important thing to do in the commit message.
Especially for small/docs patches the what/how can be nice for
when skimming the `git log` wihtout changes visible, but it's
definitively a bit less important in the commit message body.
next prev parent reply other threads:[~2024-01-10 9:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-09 14:23 [pve-devel] [PATCH manager 1/3] pvesubscription: add missing return statement Alexander Zeidler
2024-01-09 14:23 ` [pve-devel] [PATCH manager 2/3] pvesubscription: update set-offline-key description Alexander Zeidler
2024-01-10 9:41 ` Thomas Lamprecht [this message]
2024-01-10 11:03 ` Alexander Zeidler
2024-01-10 9:55 ` [pve-devel] applied: " Thomas Lamprecht
2024-01-09 14:23 ` [pve-devel] [PATCH manager 3/3] report: format iptables output for readability Alexander Zeidler
2024-01-10 9:54 ` [pve-devel] applied: " Thomas Lamprecht
2024-01-10 9:29 ` [pve-devel] [PATCH manager 1/3] pvesubscription: add missing return statement Thomas Lamprecht
2024-01-10 10:59 ` Alexander Zeidler
2024-01-29 9:51 ` Alexander Zeidler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bccb7187-575d-40ce-8b47-07f2511031eb@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=a.zeidler@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox