* [pve-devel] [PATCH manager] vzdump: include current backup when pruning dumpdir
@ 2021-09-07 11:18 Fabian Ebner
2021-09-08 10:59 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 1 reply; 2+ messages in thread
From: Fabian Ebner @ 2021-09-07 11:18 UTC (permalink / raw)
To: pve-devel
Not doing so leads to an off-by-one error, and pruning in a dumpdir
really should behave the same way as pruning in a storage.
Reported in the community forum:
https://forum.proxmox.com/threads/problem-mit-prune-backups.95737/
Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
---
PVE/VZDump.pm | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/PVE/VZDump.pm b/PVE/VZDump.pm
index b671ab19..d00be8b2 100644
--- a/PVE/VZDump.pm
+++ b/PVE/VZDump.pm
@@ -991,7 +991,7 @@ sub exec_backup_task {
debugmsg ('info', "prune older backups with retention: $keepstr", $logfd);
my $pruned = 0;
if (!defined($opts->{storage})) {
- my $bklist = get_backup_file_list($opts->{dumpdir}, $bkname, $task->{target});
+ my $bklist = get_backup_file_list($opts->{dumpdir}, $bkname);
PVE::Storage::prune_mark_backup_group($bklist, $prune_options);
foreach my $prune_entry (@{$bklist}) {
--
2.30.2
^ permalink raw reply [flat|nested] 2+ messages in thread
* [pve-devel] applied: [PATCH manager] vzdump: include current backup when pruning dumpdir
2021-09-07 11:18 [pve-devel] [PATCH manager] vzdump: include current backup when pruning dumpdir Fabian Ebner
@ 2021-09-08 10:59 ` Thomas Lamprecht
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Lamprecht @ 2021-09-08 10:59 UTC (permalink / raw)
To: Proxmox VE development discussion, Fabian Ebner
On 07.09.21 13:18, Fabian Ebner wrote:
> Not doing so leads to an off-by-one error, and pruning in a dumpdir
> really should behave the same way as pruning in a storage.
>
> Reported in the community forum:
> https://forum.proxmox.com/threads/problem-mit-prune-backups.95737/
>
> Signed-off-by: Fabian Ebner <f.ebner@proxmox.com>
> ---
> PVE/VZDump.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-09-08 11:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-07 11:18 [pve-devel] [PATCH manager] vzdump: include current backup when pruning dumpdir Fabian Ebner
2021-09-08 10:59 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox