[pve-devel] [PATCH qemu-server] vmstatus: document more return types

[pve-devel] [PATCH qemu-server] vmstatus: document more return types

[Dominik Csapak]

namely 'cpu' and 'mem'

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 PVE/QemuServer.pm | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
index b3d5f8f2..98bc07c2 100644
--- a/PVE/QemuServer.pm
+++ b/PVE/QemuServer.pm
@@ -2793,6 +2793,12 @@ our $vmstatus_return_properties = {
 	type => 'string',
 	enum => ['stopped', 'running'],
     },
+    mem => {
+	description => "Current memroy usage in bytes.",
+	type => 'integer',
+	optional => 1,
+	renderer => 'bytes',
+    },
     maxmem => {
 	description => "Maximum memory in bytes.",
 	type => 'integer',
@@ -2854,6 +2860,11 @@ our $vmstatus_return_properties = {
 	optional => 1,
 	renderer => 'duration',
     },
+    cpu => {
+	description => "Current CPU usage.",
+	type => 'number',
+	optional => 1,
+    },
     cpus => {
 	description => "Maximum usable CPUs.",
 	type => 'number',
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH container] vmstatus: document more return types

[Dominik Csapak]

namely 'cpu' and 'mem'

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
 src/PVE/LXC.pm | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/src/PVE/LXC.pm b/src/PVE/LXC.pm
index e78e365..4d20645 100644
--- a/src/PVE/LXC.pm
+++ b/src/PVE/LXC.pm
@@ -127,6 +127,12 @@ our $vmstatus_return_properties = {
 	type => 'string',
 	enum => ['stopped', 'running'],
     },
+    mem => {
+	description => "Currently used memory in bytes.",
+	type => 'integer',
+	optional => 1,
+	renderer => 'bytes',
+    },
     maxmem => {
 	description => "Maximum memory in bytes.",
 	type => 'integer',
@@ -191,6 +197,11 @@ our $vmstatus_return_properties = {
 	optional => 1,
 	renderer => 'duration',
     },
+    cpu => {
+	description => "Current CPU usage.",
+	type => 'number',
+	optional => 1,
+    },
     cpus => {
 	description => "Maximum usable CPUs.",
 	type => 'number',
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied-series: [PATCH qemu-server] vmstatus: document more return types

[Thomas Lamprecht]

Am 17.12.24 um 10:32 schrieb Dominik Csapak:
> namely 'cpu' and 'mem'
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  PVE/QemuServer.pm | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
>

applied both patches, thanks!


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH qemu-server] vmstatus: document more return types

[Daniel Kral]

On 12/17/24 10:32, Dominik Csapak wrote:
> namely 'cpu' and 'mem'
> 
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>   PVE/QemuServer.pm | 11 +++++++++++
>   1 file changed, 11 insertions(+)
> 
> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
> index b3d5f8f2..98bc07c2 100644
> --- a/PVE/QemuServer.pm
> +++ b/PVE/QemuServer.pm
> @@ -2793,6 +2793,12 @@ our $vmstatus_return_properties = {
>   	type => 'string',
>   	enum => ['stopped', 'running'],
>       },
> +    mem => {
> +	description => "Current memroy usage in bytes.",

just noticed that there's a small typo in the description

Is there a reason that the description is slightly different from the 
one in pve-container?

> +	type => 'integer',
> +	optional => 1,
> +	renderer => 'bytes',
> +    },
> [ ... ]



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH qemu-server] vmstatus: document more return types

[Dominik Csapak]

On 12/18/24 3:44 PM, Daniel Kral wrote:
> On 12/17/24 10:32, Dominik Csapak wrote:
>> namely 'cpu' and 'mem'
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>>   PVE/QemuServer.pm | 11 +++++++++++
>>   1 file changed, 11 insertions(+)
>>
>> diff --git a/PVE/QemuServer.pm b/PVE/QemuServer.pm
>> index b3d5f8f2..98bc07c2 100644
>> --- a/PVE/QemuServer.pm
>> +++ b/PVE/QemuServer.pm
>> @@ -2793,6 +2793,12 @@ our $vmstatus_return_properties = {
>>       type => 'string',
>>       enum => ['stopped', 'running'],
>>       },
>> +    mem => {
>> +    description => "Current memroy usage in bytes.",
> 
> just noticed that there's a small typo in the description
> 

true, did not notice that

> Is there a reason that the description is slightly different from the one in 
> pve-container?
> 

not really, i was probably not careful enough when writing both ;)

since this was already applied, you could send a followup to fix both issues
(if you want, otherwise I'll see when i can find the time for this)

>> +    type => 'integer',
>> +    optional => 1,
>> +    renderer => 'bytes',
>> +    },
>> [ ... ]
> 



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH qemu-server] vmstatus: document more return types

[Daniel Kral]

On 12/18/24 16:01, Dominik Csapak wrote:
> not really, i was probably not careful enough when writing both ;)
> 
> since this was already applied, you could send a followup to fix both 
> issues
> (if you want, otherwise I'll see when i can find the time for this)

Perfect, sent a quick patch to the list since I also had documenting 
these properties on my todo list for quite some time ;)


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel