From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Christoph Heiss <c.heiss@proxmox.com>
Subject: Re: [pve-devel] [PATCH installer v2 2/2] [for-9.0] auto: answer: drop deprecated snake_case keys
Date: Tue, 24 Jun 2025 16:53:06 +0200 [thread overview]
Message-ID: <bc89cd09-f4d7-4fb9-bcc4-916fc6dfce22@proxmox.com> (raw)
In-Reply-To: <20250624114102.901342-2-c.heiss@proxmox.com>
Am 24.06.25 um 13:40 schrieb Christoph Heiss:
> This has been deprecated in PVE 8.4-1 and PBS 3.4-1, respectively. The
> kebab-case style is preferred for all new things.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> Changes v1 -> v2:
> * rebased on latest master
>
> Would be nice to drop them with the next major release, if there are no
> good reasons to keep them around for another major release.
>
> The migration/fix for users is pretty simple too, for both hand-written
> answer files as well as on-the-fly generated ones from automated
> provisioning tools and such - basically a s/_/-/.
I mean, then your warning in patch 1 will never be shown anywhere
though. We could roll out patch 1 with the next major release and
mark the old variant as deprecated and drop support for real in the
first (or second) point release, then users would have at least one
ISO/release as deprecation window where the old variant still works
but one sees the warning w.r.t. the newer style.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-06-24 14:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-24 11:40 [pve-devel] [PATCH installer v2 1/2] assistant: validate: warn if answer file contains old " Christoph Heiss
2025-06-24 11:40 ` [pve-devel] [PATCH installer v2 2/2] [for-9.0] auto: answer: drop deprecated " Christoph Heiss
2025-06-24 14:53 ` Thomas Lamprecht [this message]
2025-06-24 14:54 ` [pve-devel] applied: [PATCH installer v2 1/2] assistant: validate: warn if answer file contains old " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc89cd09-f4d7-4fb9-bcc4-916fc6dfce22@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal