From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Lorenz Stechauner <l.stechauner@proxmox.com>
Subject: Re: [pve-devel] [PATCH v3 storage 1/3] status: move unlink from http-server to enpoint
Date: Tue, 31 Aug 2021 09:51:39 +0200 [thread overview]
Message-ID: <bc749266-ec20-9577-ef04-9d9065abc1a5@proxmox.com> (raw)
In-Reply-To: <231a41af-998a-4a99-9d3d-d20f78064512@proxmox.com>
On 30.08.21 13:54, Lorenz Stechauner wrote:
> On 26.08.21 18:30, Thomas Lamprecht wrote:
>> On 03/08/2021 14:16, Lorenz Stechauner wrote:
>>> @@ -486,6 +486,7 @@ __PACKAGE__->register_method ({
>>> print "command: " . join(' ', @$cmd) . "\n";
>>> eval { run_command($cmd, errmsg => 'import failed'); };
>>> + unlink $tmpfilename or warn "unable to clean up temporary file '$tmpfilename' - $!";
>> and doesn't this have the same issues as you recently fixed in regards to the node
>> not being the local one and thus ssh/scp being used?
> in this case, the local temp file is deleted and this is intended. previously, this was done by the http server.
> but it would be better to clean up the remote file as well and therefore a ssh command has to be used - could be another commit
Oh, you're right, this is only the intermediate uploaded file which is always local.
A comment could be great for that detail, but I can add that one as follow up.
next prev parent reply other threads:[~2021-08-31 7:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-03 12:16 [pve-devel] [PATCH-SERIES v3 http-server/storage/manager] fix #3505: add checksum and algorithm to iso upload Lorenz Stechauner
2021-08-03 12:16 ` [pve-devel] [PATCH v3 http-server 1/1] anyevent: move unlink from http-server to endpoint Lorenz Stechauner
2021-08-03 12:16 ` [pve-devel] [PATCH v3 storage 1/3] status: move unlink from http-server to enpoint Lorenz Stechauner
2021-08-23 16:14 ` Thomas Lamprecht
2021-08-26 16:30 ` Thomas Lamprecht
2021-08-30 11:54 ` Lorenz Stechauner
2021-08-31 7:51 ` Thomas Lamprecht [this message]
2021-08-03 12:16 ` [pve-devel] [PATCH v3 storage 2/3] status: remove sleep(1) in file upload Lorenz Stechauner
2021-08-03 12:16 ` [pve-devel] [PATCH v3 storage 3/3] fix #3505: status: add checksum and algorithm to " Lorenz Stechauner
2021-08-03 12:16 ` [pve-devel] [PATCH v3 manager 1/5] ui: move upload window into UploadToStorage.js Lorenz Stechauner
2021-08-03 12:16 ` [pve-devel] [PATCH v3 manager 2/5] ui: refactor UploadToStorage.js Lorenz Stechauner
2021-08-03 12:16 ` [pve-devel] [PATCH v3 manager 3/5] fix #3505: ui/UploadToStorage: add checksum and algorithm Lorenz Stechauner
2021-08-03 12:16 ` [pve-devel] [PATCH v3 manager 4/5] ui/UploadToStorage: add TaskViewer Lorenz Stechauner
2021-08-03 12:16 ` [pve-devel] [PATCH v3 manager 5/5] ui/UplaodToStorage: check file extension Lorenz Stechauner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc749266-ec20-9577-ef04-9d9065abc1a5@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.stechauner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox