From: Dominik Csapak <d.csapak@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: [pve-devel] superseded: [PATCH manager] ui: lxc options: fix rendering default and '0' value for tty count
Date: Mon, 17 Nov 2025 12:24:34 +0100 [thread overview]
Message-ID: <bc721150-b4b7-4999-a5ef-5519fa7fd58a@proxmox.com> (raw)
In-Reply-To: <20251117092110.628324-1-d.csapak@proxmox.com>
superseded by two patches:
https://lore.proxmox.com/pve-devel/20251117092110.628324-1-d.csapak@proxmox.com/
https://lore.proxmox.com/pve-devel/20251117112334.1400372-1-d.csapak@proxmox.com/
On 11/17/25 10:21 AM, Dominik Csapak wrote:
> if '0' was entered, the options grid would show an empty line. Fix that
> by adding a renderer that checks if the value is a number.
>
> If the default is set, the edit window would always pre-fill the value
> '2' instead of leaving the field empty. Fix that by removing the
> manually set 'value' property.
>
> Reported-by: Dietmar Maurer <dietmar@proxmox.com>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> www/manager6/lxc/Options.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/lxc/Options.js b/www/manager6/lxc/Options.js
> index 6cc2e2b4..0acb88f4 100644
> --- a/www/manager6/lxc/Options.js
> +++ b/www/manager6/lxc/Options.js
> @@ -81,6 +81,7 @@ Ext.define('PVE.lxc.Options', {
> tty: {
> header: gettext('TTY count'),
> defaultValue: 2,
> + renderer: (value) => (Ext.isNumber(value) ? value : '2'),
> editor: caps.vms['VM.Config.Options']
> ? {
> xtype: 'proxmoxWindowEdit',
> @@ -90,7 +91,6 @@ Ext.define('PVE.lxc.Options', {
> name: 'tty',
> minValue: 0,
> maxValue: 6,
> - value: 2,
> fieldLabel: gettext('TTY count'),
> emptyText: gettext('Default'),
> deleteEmpty: true,
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-11-17 11:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-17 9:21 [pve-devel] " Dominik Csapak
2025-11-17 10:41 ` Thomas Lamprecht
2025-11-17 11:09 ` Dominik Csapak
2025-11-17 11:24 ` Dominik Csapak [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bc721150-b4b7-4999-a5ef-5519fa7fd58a@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox