public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Oguz Bektas <o.bektas@proxmox.com>
Subject: [pve-devel] applied: [PATCH docs] pve-network.adoc: add spaces to separate links on newlines
Date: Mon, 31 Aug 2020 12:07:15 +0200	[thread overview]
Message-ID: <bc000d4a-7765-2611-3712-4003948c135b@proxmox.com> (raw)
In-Reply-To: <20200831092347.51264-1-o.bektas@proxmox.com>

On 31.08.20 11:23, Oguz Bektas wrote:
> otherwise they all show up in one line on the wiki
> 
> Signed-off-by: Oguz Bektas <o.bektas@proxmox.com>
> ---
>  pve-network.adoc | 3 +++
>  1 file changed, 3 insertions(+)
> 
>

OK, but I do not want things like "pve-network.adoc" as commit subject tag, this
is for humans to get the context (rough category) of what the patch affects, if
I want to know the affected files in git log I just use the "--stat" flag, the patch
mail has it already anyway.

I changed it to:
> network: nat: add extra newlines between links for readability

and clarified that this affected all rendere outputs, i.e., also pdf and html.

applied, thanks!





      reply	other threads:[~2020-08-31 10:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-31  9:23 [pve-devel] " Oguz Bektas
2020-08-31 10:07 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bc000d4a-7765-2611-3712-4003948c135b@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=o.bektas@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal