* [pve-devel] [PATCH manager] GUI: disk reassign: remove unused reference and bind
@ 2022-05-02 14:24 Matthias Heiserer
2022-05-02 14:32 ` Aaron Lauterer
2022-05-02 14:45 ` [pve-devel] applied: " Thomas Lamprecht
0 siblings, 2 replies; 3+ messages in thread
From: Matthias Heiserer @ 2022-05-02 14:24 UTC (permalink / raw)
To: pve-devel
They are not used anywhere else, so I assume they were left over from
an earlier version.
Also, sometimes "[object object] flashes in the Target Guest field when
opening the reassign window, with this removed it doesn't occur.
Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
---
www/manager6/window/GuestDiskReassign.js | 4 ----
1 file changed, 4 deletions(-)
diff --git a/www/manager6/window/GuestDiskReassign.js b/www/manager6/window/GuestDiskReassign.js
index 3795475d..f6d08b32 100644
--- a/www/manager6/window/GuestDiskReassign.js
+++ b/www/manager6/window/GuestDiskReassign.js
@@ -132,13 +132,9 @@ Ext.define('PVE.window.GuestDiskReassign', {
},
{
xtype: 'vmComboSelector',
- reference: 'targetVMID',
name: 'targetVmid',
allowBlank: false,
fieldLabel: gettext('Target Guest'),
- bind: {
- value: '{targetVMID}',
- },
store: {
model: 'PVEResources',
autoLoad: true,
--
2.30.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [pve-devel] [PATCH manager] GUI: disk reassign: remove unused reference and bind
2022-05-02 14:24 [pve-devel] [PATCH manager] GUI: disk reassign: remove unused reference and bind Matthias Heiserer
@ 2022-05-02 14:32 ` Aaron Lauterer
2022-05-02 14:45 ` [pve-devel] applied: " Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Aaron Lauterer @ 2022-05-02 14:32 UTC (permalink / raw)
To: Proxmox VE development discussion, Matthias Heiserer
thanks for catching this!
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
On 5/2/22 16:24, Matthias Heiserer wrote:
> They are not used anywhere else, so I assume they were left over from
> an earlier version.
> Also, sometimes "[object object] flashes in the Target Guest field when
> opening the reassign window, with this removed it doesn't occur.
>
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
> www/manager6/window/GuestDiskReassign.js | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/www/manager6/window/GuestDiskReassign.js b/www/manager6/window/GuestDiskReassign.js
> index 3795475d..f6d08b32 100644
> --- a/www/manager6/window/GuestDiskReassign.js
> +++ b/www/manager6/window/GuestDiskReassign.js
> @@ -132,13 +132,9 @@ Ext.define('PVE.window.GuestDiskReassign', {
> },
> {
> xtype: 'vmComboSelector',
> - reference: 'targetVMID',
> name: 'targetVmid',
> allowBlank: false,
> fieldLabel: gettext('Target Guest'),
> - bind: {
> - value: '{targetVMID}',
> - },
> store: {
> model: 'PVEResources',
> autoLoad: true,
^ permalink raw reply [flat|nested] 3+ messages in thread
* [pve-devel] applied: [PATCH manager] GUI: disk reassign: remove unused reference and bind
2022-05-02 14:24 [pve-devel] [PATCH manager] GUI: disk reassign: remove unused reference and bind Matthias Heiserer
2022-05-02 14:32 ` Aaron Lauterer
@ 2022-05-02 14:45 ` Thomas Lamprecht
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2022-05-02 14:45 UTC (permalink / raw)
To: Proxmox VE development discussion, Matthias Heiserer
Am 5/2/22 um 16:24 schrieb Matthias Heiserer:
> They are not used anywhere else, so I assume they were left over from
> an earlier version.
> Also, sometimes "[object object] flashes in the Target Guest field when
> opening the reassign window, with this removed it doesn't occur.
>
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
> www/manager6/window/GuestDiskReassign.js | 4 ----
> 1 file changed, 4 deletions(-)
>
>
applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2022-05-02 14:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-02 14:24 [pve-devel] [PATCH manager] GUI: disk reassign: remove unused reference and bind Matthias Heiserer
2022-05-02 14:32 ` Aaron Lauterer
2022-05-02 14:45 ` [pve-devel] applied: " Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox