From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Matthias Heiserer <m.heiserer@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] GUI: disk reassign: remove unused reference and bind
Date: Mon, 2 May 2022 16:32:40 +0200 [thread overview]
Message-ID: <bbe83a7e-83bf-5475-b306-5e9338fec882@proxmox.com> (raw)
In-Reply-To: <20220502142423.749183-1-m.heiserer@proxmox.com>
thanks for catching this!
Tested-By: Aaron Lauterer <a.lauterer@proxmox.com>
On 5/2/22 16:24, Matthias Heiserer wrote:
> They are not used anywhere else, so I assume they were left over from
> an earlier version.
> Also, sometimes "[object object] flashes in the Target Guest field when
> opening the reassign window, with this removed it doesn't occur.
>
> Signed-off-by: Matthias Heiserer <m.heiserer@proxmox.com>
> ---
> www/manager6/window/GuestDiskReassign.js | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/www/manager6/window/GuestDiskReassign.js b/www/manager6/window/GuestDiskReassign.js
> index 3795475d..f6d08b32 100644
> --- a/www/manager6/window/GuestDiskReassign.js
> +++ b/www/manager6/window/GuestDiskReassign.js
> @@ -132,13 +132,9 @@ Ext.define('PVE.window.GuestDiskReassign', {
> },
> {
> xtype: 'vmComboSelector',
> - reference: 'targetVMID',
> name: 'targetVmid',
> allowBlank: false,
> fieldLabel: gettext('Target Guest'),
> - bind: {
> - value: '{targetVMID}',
> - },
> store: {
> model: 'PVEResources',
> autoLoad: true,
next prev parent reply other threads:[~2022-05-02 14:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-02 14:24 Matthias Heiserer
2022-05-02 14:32 ` Aaron Lauterer [this message]
2022-05-02 14:45 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bbe83a7e-83bf-5475-b306-5e9338fec882@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=m.heiserer@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox