public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Manuel Federanko <m.federanko@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [PATCH-SERIES qemu-server 0/2] hotplug pending: only issue QMP commands related to USB hotplug if actually needed
Date: Tue, 31 Mar 2026 16:29:01 +0200	[thread overview]
Message-ID: <bbdb3bf4-96ac-4c90-9a53-75e74b2a2abe@proxmox.com> (raw)
In-Reply-To: <20260330110954.82174-1-f.ebner@proxmox.com>

On 2026-03-30 1:09 PM, Fiona Ebner wrote:
> There is a report in the enterprise support about Veeam failing to set
> the 'lock' property in the VM configuration, because they are blocking
> the QMP socket. The proper fix would be for them to not block the QMP
> socket (at least not while interacting with our API), but there still
> is an improvement to be made on the Proxmox VE side, which is to avoid
> doing QMP commands related to USB hotplug if they are not actually
> needed.
> 
> qemu-server:
> 
> Fiona Ebner (2):
>   hotplug pending: only check if USB devices are left when one was
>     unplugged
>   hotplug pending: only check for USB hoptplug support when actually
>     needed
> 
>  src/PVE/QemuServer.pm | 41 ++++++++++++++++++++++++++++++-----------
>  1 file changed, 30 insertions(+), 11 deletions(-)
> 
> 
> Summary over all repositories:
>   1 files changed, 30 insertions(+), 11 deletions(-)
> 

Thanks!

Tested this by blocking the QMP socket and acquiring a lock on the
guest afterwards, also tried to add a USB device while blocking the
socket, which times out as expected.

Tested-by: Manuel Federanko <m.federanko@proxmox.com>




  parent reply	other threads:[~2026-03-31 14:28 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-30 11:09 Fiona Ebner
2026-03-30 11:09 ` [PATCH qemu-server 1/2] hotplug pending: only check if USB devices are left when one was unplugged Fiona Ebner
2026-03-30 11:09 ` [PATCH qemu-server 2/2] hotplug pending: only check for USB hoptplug support when actually needed Fiona Ebner
2026-03-31 14:29 ` Manuel Federanko [this message]
2026-03-31 18:40 ` applied: [PATCH-SERIES qemu-server 0/2] hotplug pending: only issue QMP commands related to USB hotplug if " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bbdb3bf4-96ac-4c90-9a53-75e74b2a2abe@proxmox.com \
    --to=m.federanko@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal