From: Aaron Lauterer <a.lauterer@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH widget-toolkit/manager v2 0/4] Ceph OSD: add detail infos
Date: Tue, 18 Oct 2022 11:14:27 +0200 [thread overview]
Message-ID: <bb71fb66-e832-1380-7a57-02a359a58fcb@proxmox.com> (raw)
In-Reply-To: <e6129377-9d6d-3412-de9f-152db3806dfb@proxmox.com>
On 10/17/22 16:29, Dominik Csapak wrote:
> high level looks mostly good, a small question:
>
> is there a special reason why we ignore pre-lvm osds here?
> AFAICS, we simply error out for osds that don't live on lvm
> (though we can add additional types later i guess)
Mainly because with a recent Ceph version, you shouldn't have any pre Bluestore
OSDs anymore. With Quincy, they have officially been deprecated. And even
before, for quite a few versions, every new OSD would be a bluestore one.
So I did not want to do the work for the old filestore OSDs. Once a new
generation of OSDs becomes available, we will need to handle them as well though.
>
> comments in the individual patches
>
next prev parent reply other threads:[~2022-10-18 9:14 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-06 13:01 Aaron Lauterer
2022-07-06 13:01 ` [pve-devel] [PATCH widget-toolkit v2 1/4] ObjectGrid: optionally show loading mask on load Aaron Lauterer
2022-10-17 14:29 ` Dominik Csapak
2022-07-06 13:01 ` [pve-devel] [PATCH manager v2 2/4] api ceph osd: add OSD index, metadata and lv-info Aaron Lauterer
2022-10-17 14:29 ` Dominik Csapak
2022-07-06 13:01 ` [pve-devel] [PATCH manager v2 3/4] ui utils: add renderer for ceph osd addresses Aaron Lauterer
2022-10-17 14:29 ` Dominik Csapak
2022-07-06 13:01 ` [pve-devel] [PATCH manager v2 4/4] ui: osd: add details window Aaron Lauterer
2022-10-17 14:30 ` Dominik Csapak
2022-10-12 12:09 ` [pve-devel] [PATCH widget-toolkit/manager v2 0/4] Ceph OSD: add detail infos Aaron Lauterer
2022-10-17 14:29 ` Dominik Csapak
2022-10-18 9:14 ` Aaron Lauterer [this message]
2022-10-19 6:46 ` Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb71fb66-e832-1380-7a57-02a359a58fcb@proxmox.com \
--to=a.lauterer@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox