From: Mira Limbeck <m.limbeck@proxmox.com>
To: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH manager 5/7] report: overhaul `dmidecode` related output
Date: Thu, 18 Apr 2024 12:24:45 +0200 [thread overview]
Message-ID: <bb31bcf4-75e7-4252-a0a1-4847ec7af7e4@proxmox.com> (raw)
In-Reply-To: <20240418091650.51366-5-a.zeidler@proxmox.com>
On 4/18/24 11:16, Alexander Zeidler wrote:
> While using keywords (-t bios,...) would be possible, depending on the
> server it also bloats the report with uninteresting information,
> hiding the relevant.
>
> Therefore the non-grouped, specific number types are used. Where we
> only need specific information, not serial numbers etc., we print the
> information from /sys/... which is the same source that dmidecode uses
> per default.
>
> New output includes:
>
> sys_vendor: HP
> product_name: ProLiant DL380p Gen8
> product_version: Not specified
Would it be possible to align these correctly, or just use a single
space between type and value?
>> and
>
> board_vendor: ASUSTeK COMPUTER INC.
> board_name: Z13PP-D32 Series
> board_version: 60SB09M0-SB0G11
>
> also because there are not always both data blocks available.
>
> `-t 0`:
> (like the previous "BIOS" output, but without "BIOS Language" block)
>
> `-t 3`:
> Chassis Information
> Manufacturer: HP
> Type: Rack Mount Chassis
> Boot-up State: Critical
> Power Supply State: Critical
> Thermal State: Safe
> Number Of Power Cords: 2
> (...)
>
> and
>
> `-t 32`:
> System Boot Information
> Status: Firmware-detected hardware failure
>
> which can hint to Proxmox-independant issues, debug-able via IPMI.
>
> Signed-off-by: Alexander Zeidler <a.zeidler@proxmox.com>
> ---
> v2:
> * reformat and extend board output
> * add product output
> * adapt dmidecode output
>
> v1: https://lists.proxmox.com/pipermail/pve-devel/2024-March/062350.html
>
>
> PVE/Report.pm | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/Report.pm b/PVE/Report.pm
> index 1ed91c8e..9d1b9b27 100644
> --- a/PVE/Report.pm
> +++ b/PVE/Report.pm
> @@ -110,7 +110,9 @@ my $init_report_cmds = sub {
> hardware => {
> order => 70,
> cmds => [
> - 'dmidecode -t bios',
> + 'cd /sys/devices/virtual/dmi/id; grep -HT "" sys_vendor product_name product_version',
> + 'cd /sys/devices/virtual/dmi/id; grep -HT "" board_vendor board_name board_version',
I'd prefer explicit commands like:
cat /sys/devices/virtual/dmi/id/sys_vendor
cat /sys/devices/virtual/dmi/id/product_name
cat /sys/devices/virtual/dmi/id/product_version
This results in a few more lines in the report, since we have the
following structure:
# <command>
<output of command>
<newline>
# <command>
...
Adding at least one additional newline per file read, but there would be
no need for cd-ing, printing the filename with grep and trying to align
the output.
> + 'dmidecode -t 0,3,32',
> 'lspci -nnk',
> ],
> },
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-04-18 10:24 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-18 9:16 [pve-devel] [PATCH manager 1/7] report: add kernel command line from current boot Alexander Zeidler
2024-04-18 9:16 ` [pve-devel] [PATCH manager 2/7] report: create "jobs" section, add `jobs.cfg` Alexander Zeidler
2024-04-18 20:25 ` [pve-devel] applied: " Thomas Lamprecht
2024-04-18 9:16 ` [pve-devel] [PATCH manager 3/7] report: add `apt-cache policy` to list recognized APT sources Alexander Zeidler
2024-04-18 20:28 ` [pve-devel] applied: " Thomas Lamprecht
2024-04-18 9:16 ` [pve-devel] [PATCH manager 4/7] report: list held back packages Alexander Zeidler
2024-04-18 20:28 ` [pve-devel] applied: " Thomas Lamprecht
2024-04-18 9:16 ` [pve-devel] [PATCH manager 5/7] report: overhaul `dmidecode` related output Alexander Zeidler
2024-04-18 10:24 ` Mira Limbeck [this message]
2024-04-18 12:30 ` Alexander Zeidler
2024-04-18 9:16 ` [pve-devel] [PATCH manager 6/7] report: add info about (un)used memory slots Alexander Zeidler
2024-04-18 10:16 ` Aaron Lauterer
2024-04-18 13:32 ` Alexander Zeidler
2024-04-18 10:20 ` Mira Limbeck
2024-04-18 13:38 ` Alexander Zeidler
2024-04-18 9:16 ` [pve-devel] [PATCH manager 7/7] report: add recent boot timestamps which may show fencing/crash events Alexander Zeidler
2024-04-18 10:43 ` Mira Limbeck
2024-04-18 15:45 ` Alexander Zeidler
2024-04-19 8:56 ` Mira Limbeck
2024-04-18 9:19 ` [pve-devel] [PATCH manager 1/7] report: add kernel command line from current boot Alexander Zeidler
2024-04-18 10:16 ` Aaron Lauterer
2024-04-18 11:05 ` Mira Limbeck
2024-04-18 15:46 ` Alexander Zeidler
2024-04-18 20:25 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bb31bcf4-75e7-4252-a0a1-4847ec7af7e4@proxmox.com \
--to=m.limbeck@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox