public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
	Gandalf Corvotempesta <gandalf.corvotempesta@gmail.com>
Subject: Re: [pve-devel] Direct migration from XenServer to PVE
Date: Thu, 28 Jan 2021 16:55:04 +0100	[thread overview]
Message-ID: <ba6aa8c3-7c55-8abf-b427-57d3b6adaae0@proxmox.com> (raw)
In-Reply-To: <CAJH6TXgwKTpAZ_Jp=dGB__G+EGaJ_MxsSpFrV4EPPuHZWx8Hrw@mail.gmail.com>

Ciao,

On 27.01.21 10:13, Gandalf Corvotempesta wrote:
> Ciao,
> i'm the author of this simple tool: https://github.com/guestisp/xen-to-pve
> 
> it works by exporting a XenServer DomU directly to PVE in one phase,
> there is no need to export, extract, join each chunks and so. Just
> call it and a new image file is made.
> 
> But there is one issue that i'm unable to resolve: the image should be
> imported with "qm import"
> This lead to loss of time (an additional step is needed) and space
> wasted (the image coming from XenServer should be stored somewhere on
> PVE and then imported).
> 
> I would like to write directly to the ZFS volume .

Would it be enough if `qm importdisk` would accept stdin as source as long
as the image size explicitly passed as a paramter?

As that'd seem reasonable and help with other import issues too as one
could just pipe the data over ssh from the source server directly into
importdisk, no intermediate required.


> Can someone tell me how to do that or , even better, make a PR ?
> 

If above is OK then adding special handling to use stdin for when $source
equals "-" and adding a new "size" parameter, which is in general optional
but required for the "-" case.

That change should be limited to editing the CLI definition[0] and the
method doing the actual import[1].

cheers,
Thomas

[0]: https://git.proxmox.com/?p=qemu-server.git;a=blob;f=PVE/CLI/qm.pm;h=1aa273f39a373594eea0c1dc866e6b245d97e99e;hb=HEAD#l443
[1]: https://git.proxmox.com/?p=qemu-server.git;a=blob;f=PVE/QemuServer/ImportDisk.pm;h=51ad52eab43ebad24a104de116dc5eea88587c7a;hb=HEAD





  reply	other threads:[~2021-01-28 15:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-27  9:13 Gandalf Corvotempesta
2021-01-28 15:55 ` Thomas Lamprecht [this message]
2021-01-31 13:06   ` Gandalf Corvotempesta

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ba6aa8c3-7c55-8abf-b427-57d3b6adaae0@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=gandalf.corvotempesta@gmail.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal