From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox VE development discussion <pve-devel@lists.proxmox.com>,
Friedrich Weber <f.weber@proxmox.com>
Subject: [pve-devel] applied: [PATCH qemu-server] fix: api: fix permission check for cloudinit drive update
Date: Tue, 25 Jul 2023 17:23:35 +0200 [thread overview]
Message-ID: <ba55ce15-fa7a-402a-890b-a3d7b06db1c3@proxmox.com> (raw)
In-Reply-To: <20230313125625.1060320-1-f.weber@proxmox.com>
On 13/03/2023 13:56, Friedrich Weber wrote:
> Trying to regenerate a cloudinit drive as a non-root user via the API
> currently throws a Perl error, as reported in the forum [1]. This is
> due to a type mismatch in the permission check, where a string is
> passed but an array is expected.
>
> [1] https://forum.proxmox.com/threads/regenerate-cloudinit-by-put-api-return-500.124099/
>
> Signed-off-by: Friedrich Weber <f.weber@proxmox.com>
> ---
> To see if we have the same problem for other API endpoints, I ran:
> grep -r "['\"]perm['\"][^[]*]" .
> in my locally checked-out repos, but found only this single occurrence.
>
> PVE/API2/Qemu.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>
applied, thanks!
prev parent reply other threads:[~2023-07-25 15:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-13 12:56 [pve-devel] " Friedrich Weber
2023-07-24 11:46 ` Friedrich Weber
2023-07-25 15:23 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ba55ce15-fa7a-402a-890b-a3d7b06db1c3@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=f.weber@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox